]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Revert "Improve pg_basebackup long file name test Windows robustness"
authorAndrew Dunstan <andrew@dunslane.net>
Mon, 3 Jul 2023 14:53:16 +0000 (10:53 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Mon, 3 Jul 2023 14:53:16 +0000 (10:53 -0400)
Version 12 and older are missing the required infrastructure.

src/bin/pg_basebackup/t/010_pg_basebackup.pl

index dede83f398ae780c12ba5f02945659d75a3bb1bb..29d0ae0a42c243c52a7350ec72b7043263b888ca 100644 (file)
@@ -197,12 +197,8 @@ $node->command_fails(
        '-T with invalid format fails');
 
 # Tar format doesn't support filenames longer than 100 bytes.
-# Create the test file via a short name directory so it doesn't blow the
-# Windows path limit.
-my $lftmp = TestLib::tempdir_short;
-dir_symlink "$pgdata", "$lftmp/pgdata";
 my $superlongname = "superlongname_" . ("x" x 100);
-my $superlongpath = "$lftmp/pgdata/$superlongname";
+my $superlongpath = "$pgdata/$superlongname";
 
 open my $file, '>', "$superlongpath"
   or die "unable to create file $superlongpath";
@@ -210,7 +206,7 @@ close $file;
 $node->command_fails(
        [ 'pg_basebackup', '-D', "$tempdir/tarbackup_l1", '-Ft' ],
        'pg_basebackup tar with long name fails');
-unlink "$superlongpath";
+unlink "$pgdata/$superlongname";
 
 # The following tests test symlinks. Windows doesn't have symlinks, so
 # skip on Windows.