]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: tc358767: Use dev_err_probe
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Wed, 4 Sep 2024 12:05:43 +0000 (14:05 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 13 Sep 2024 08:10:16 +0000 (10:10 +0200)
The function calls preceding these returns can return -EPROBE_DEFER. So
use dev_err_probe to add some information to
/sys/kernel/debug/devices_deferred

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240904120546.1845856-2-alexander.stein@ew.tq-group.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240904120546.1845856-2-alexander.stein@ew.tq-group.com
drivers/gpu/drm/bridge/tc358767.c

index 290e2532fab19125aeb2cdf45b6bb013ae800af3..5ef33ce33dcaa4d125d1c7bab6e72b118b1819f7 100644 (file)
@@ -2298,7 +2298,8 @@ static int tc_probe_dpi_bridge_endpoint(struct tc_data *tc)
        /* port@1 is the DPI input/output port */
        ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &panel, &bridge);
        if (ret && ret != -ENODEV)
-               return ret;
+               return dev_err_probe(dev, ret,
+                                    "Could not find DPI panel or bridge\n");
 
        if (panel) {
                bridge = devm_drm_panel_bridge_add(dev, panel);
@@ -2326,7 +2327,8 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
        /* port@2 is the output port */
        ret = drm_of_find_panel_or_bridge(dev->of_node, 2, 0, &panel, NULL);
        if (ret && ret != -ENODEV)
-               return ret;
+               return dev_err_probe(dev, ret,
+                                    "Could not find DSI panel or bridge\n");
 
        if (panel) {
                struct drm_bridge *panel_bridge;
@@ -2550,7 +2552,7 @@ static int tc_probe(struct i2c_client *client)
                ret = tc_mipi_dsi_host_attach(tc);
                if (ret) {
                        drm_bridge_remove(&tc->bridge);
-                       return ret;
+                       return dev_err_probe(dev, ret, "Failed to attach DSI host\n");
                }
        }