]> git.ipfire.org Git - pakfire.git/commitdiff
libpakfire: Drop Pool
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 19 Jan 2018 15:47:54 +0000 (16:47 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 19 Jan 2018 15:47:54 +0000 (16:47 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
32 files changed:
Makefile.am
src/_pakfire/_pakfiremodule.c
src/_pakfire/pool.c [deleted file]
src/_pakfire/pool.h [deleted file]
src/_pakfire/problem.c
src/_pakfire/relation.c
src/_pakfire/relation.h
src/_pakfire/solution.c
src/_pakfire/transaction.c
src/libpakfire/include/pakfire/pakfire.h
src/libpakfire/include/pakfire/pool.h [deleted file]
src/libpakfire/include/pakfire/relation.h
src/libpakfire/include/pakfire/repo.h
src/libpakfire/include/pakfire/request.h
src/libpakfire/include/pakfire/transaction.h
src/libpakfire/include/pakfire/types.h
src/libpakfire/libpakfire.sym
src/libpakfire/package.c
src/libpakfire/packagelist.c
src/libpakfire/pakfire.c
src/libpakfire/pool.c [deleted file]
src/libpakfire/relation.c
src/libpakfire/relationlist.c
src/libpakfire/repo.c
src/libpakfire/request.c
src/libpakfire/selector.c
src/libpakfire/step.c
src/libpakfire/transaction.c
src/pakfire/base.py
src/pakfire/packages/base.py
src/pakfire/repository/__init__.py
src/pakfire/util.py

index dda193540bfe8620b387dfbbdc936ef1c6cfb2ee..1b7af8691dbd44360f4ad74c63434f08fd543847 100644 (file)
@@ -196,8 +196,6 @@ _pakfire_la_SOURCES = \
        src/_pakfire/package.h \
        src/_pakfire/pakfire.c \
        src/_pakfire/pakfire.h \
-       src/_pakfire/pool.c \
-       src/_pakfire/pool.h \
        src/_pakfire/problem.c \
        src/_pakfire/problem.h \
        src/_pakfire/relation.c \
@@ -254,7 +252,6 @@ libpakfire_la_SOURCES = \
        src/libpakfire/package.c \
        src/libpakfire/packagelist.c \
        src/libpakfire/pakfire.c \
-       src/libpakfire/pool.c \
        src/libpakfire/problem.c \
        src/libpakfire/relation.c \
        src/libpakfire/relationlist.c \
@@ -279,7 +276,6 @@ pkginclude_HEADERS += \
        src/libpakfire/include/pakfire/package.h \
        src/libpakfire/include/pakfire/packagelist.h \
        src/libpakfire/include/pakfire/pakfire.h \
-       src/libpakfire/include/pakfire/pool.h \
        src/libpakfire/include/pakfire/private.h \
        src/libpakfire/include/pakfire/problem.h \
        src/libpakfire/include/pakfire/relation.h \
index 0f73f0d43f5c5b16704aa695cce56165943eb020..a922e8cbaa870c9f7781bce621b982245bdb9685 100644 (file)
@@ -34,7 +34,6 @@
 #include "key.h"
 #include "package.h"
 #include "pakfire.h"
-#include "pool.h"
 #include "problem.h"
 #include "relation.h"
 #include "repo.h"
@@ -121,12 +120,6 @@ PyMODINIT_FUNC PyInit__pakfire(void) {
        Py_INCREF(&PackageType);
        PyModule_AddObject(module, "Package", (PyObject *)&PackageType);
 
-       // Pool
-       if (PyType_Ready(&PoolType) < 0)
-               return NULL;
-       Py_INCREF(&PoolType);
-       PyModule_AddObject(module, "Pool", (PyObject *)&PoolType);
-
        // Problem
        if (PyType_Ready(&ProblemType) < 0)
                return NULL;
diff --git a/src/_pakfire/pool.c b/src/_pakfire/pool.c
deleted file mode 100644 (file)
index 83fde72..0000000
+++ /dev/null
@@ -1,75 +0,0 @@
-/*#############################################################################
-#                                                                             #
-# Pakfire - The IPFire package management system                              #
-# Copyright (C) 2011 Pakfire development team                                 #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-#############################################################################*/
-
-#include <Python.h>
-#include <fnmatch.h>
-#include <solv/poolarch.h>
-#include <solv/solver.h>
-
-#include <pakfire/errno.h>
-#include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
-#include <pakfire/repo.h>
-
-#include "constants.h"
-#include "pakfire.h"
-#include "pool.h"
-#include "relation.h"
-#include "util.h"
-
-static PyObject* Pool_new(PyTypeObject* type, PyObject* args, PyObject* kwds) {
-       PoolObject* self = (PoolObject *)type->tp_alloc(type, 0);
-       if (self) {
-               self->pool = NULL;
-       }
-
-       return (PyObject *)self;
-}
-
-static void Pool_dealloc(PoolObject* self) {
-       if (self->pool)
-               pakfire_pool_unref(self->pool);
-
-       Py_TYPE(self)->tp_free((PyObject *)self);
-}
-
-static int Pool_init(PoolObject* self, PyObject* args, PyObject* kwds) {
-       PakfireObject* pakfire = NULL;
-
-       if (!PyArg_ParseTuple(args, "O!", &PakfireType, &pakfire))
-               return -1;
-
-       self->pool = pakfire_get_pool(pakfire->pakfire);
-       if (!self->pool)
-               return -1;
-
-       return 0;
-}
-
-PyTypeObject PoolType = {
-       PyVarObject_HEAD_INIT(NULL, 0)
-       tp_name:            "_pakfire.Pool",
-       tp_basicsize:       sizeof(PoolObject),
-       tp_flags:           Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
-       tp_new:             Pool_new,
-       tp_dealloc:         (destructor)Pool_dealloc,
-       tp_init:            (initproc)Pool_init,
-       tp_doc:             "Pool object",
-};
diff --git a/src/_pakfire/pool.h b/src/_pakfire/pool.h
deleted file mode 100644 (file)
index 80f90e7..0000000
+++ /dev/null
@@ -1,35 +0,0 @@
-/*#############################################################################
-#                                                                             #
-# Pakfire - The IPFire package management system                              #
-# Copyright (C) 2011 Pakfire development team                                 #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-#############################################################################*/
-
-#ifndef PYTHON_PAKFIRE_POOL_H
-#define PYTHON_PAKFIRE_POOL_H
-
-#include <Python.h>
-
-#include <pakfire/pool.h>
-
-typedef struct {
-       PyObject_HEAD
-       PakfirePool pool;
-} PoolObject;
-
-extern PyTypeObject PoolType;
-
-#endif /* PYTHON_PAKFIRE_POOL_H */
index 51f5ca6c54aa0dbe113aa37248fd53c47074a09a..6792f6c14d910868811147905b2313bd713b21c6 100644 (file)
@@ -24,7 +24,6 @@
 #include <pakfire/errno.h>
 #include <pakfire/problem.h>
 
-#include "pool.h"
 #include "problem.h"
 #include "solution.h"
 
index 5085df62bdc16be9237a3ca464222c5360924189..0c0807be5b174b3b61b66982ddec6b527b043c92 100644 (file)
@@ -58,7 +58,7 @@ static PyObject* Relation_new(PyTypeObject* type, PyObject* args, PyObject* kwds
 static void Relation_dealloc(RelationObject* self) {
        pakfire_relation_unref(self->relation);
 
-       Py_XDECREF(self->pool);
+       Py_XDECREF(self->pakfire);
        Py_TYPE(self)->tp_free((PyObject *)self);
 }
 
index 2c184149556f29a4cd2ab862f49f44fcb5bdf152..ee04992a9375fed2755433b71a6c248f072cfaf9 100644 (file)
 
 #include <Python.h>
 
-#include <solv/pooltypes.h>
-#include <pakfire/relation.h>
+#include <pakfire/types.h>
 
 #include "pakfire.h"
-#include "pool.h"
 
 typedef struct {
     PyObject_HEAD
     PakfireObject* pakfire;
-    PoolObject* pool;
     PakfireRelation relation;
-
-       // XXX COMPAT
-       Pool* _pool;
-       Id _id;
 } RelationObject;
 
 extern PyTypeObject RelationType;
index 9475ed79957cfb4b55e149fa48443e546c37d2cb..309f3c587fc2935c382031f39f9e05d4cfbb672c 100644 (file)
@@ -24,7 +24,6 @@
 #include <pakfire/errno.h>
 #include <pakfire/solution.h>
 
-#include "pool.h"
 #include "solution.h"
 
 static SolutionObject* Solution_new_core(PyTypeObject* type, PakfireSolution solution) {
index 8c325feace62203bdb49b8c84afa01dc3f254a59..ee394a89723f4d4f5f013c950e300946ad73367e 100644 (file)
@@ -22,7 +22,6 @@
 
 #include <pakfire/package.h>
 #include <pakfire/packagelist.h>
-#include <pakfire/pool.h>
 #include <pakfire/transaction.h>
 
 #include "package.h"
index 661c83934980bcf0b3327216f58df14955601bb0..d7c34f75711bbce3c3fada7c90a02495d475fb6a 100644 (file)
@@ -38,8 +38,6 @@ Pakfire pakfire_unref(Pakfire pakfire);
 const char* pakfire_get_path(Pakfire pakfire);
 const char* pakfire_get_arch(Pakfire pakfire);
 
-PakfirePool pakfire_get_pool(Pakfire pakfire);
-
 const char** pakfire_get_installonly(Pakfire pakfire);
 void pakfire_set_installonly(Pakfire pakfire, const char** installonly);
 
diff --git a/src/libpakfire/include/pakfire/pool.h b/src/libpakfire/include/pakfire/pool.h
deleted file mode 100644 (file)
index 24d64ab..0000000
+++ /dev/null
@@ -1,39 +0,0 @@
-/*#############################################################################
-#                                                                             #
-# Pakfire - The IPFire package management system                              #
-# Copyright (C) 2013 Pakfire development team                                 #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-#############################################################################*/
-
-#ifndef PAKFIRE_POOL_H
-#define PAKFIRE_POOL_H
-
-#include <pakfire/types.h>
-
-PakfirePool pakfire_pool_create(Pakfire pakfire);
-
-PakfirePool pakfire_pool_ref(PakfirePool pool);
-PakfirePool pakfire_pool_unref(PakfirePool pool);
-
-#ifdef PAKFIRE_PRIVATE
-
-#include <solv/pool.h>
-
-Pool* pakfire_pool_get_solv_pool(PakfirePool pool);
-
-#endif
-
-#endif /* PAKFIRE_POOL_H */
index 9ab8ded1c981293418acd439aa0e157ccc61bb59..1e6b7b258b9ae0148eb9e65ed7625b5d6f7f0b18 100644 (file)
@@ -25,7 +25,6 @@
 #include <solv/pooltypes.h>
 #include <solv/queue.h>
 
-#include <pakfire/pool.h>
 #include <pakfire/types.h>
 
 PakfireRelation pakfire_relation_create(Pakfire pakfire, const char* name, int cmp_type, const char* evr);
index d65b83b67c7f633d517a82c92ead02959ef7b996..192aab5c46a58efed9899478256db5c02576b276 100644 (file)
@@ -31,8 +31,6 @@ PakfireRepo pakfire_repo_create(Pakfire pakfire, const char* name);
 PakfireRepo pakfire_repo_ref(PakfireRepo repo);
 PakfireRepo pakfire_repo_unref(PakfireRepo repo);
 
-PakfirePool pakfire_repo_get_pool(PakfireRepo repo);
-
 int pakfire_repo_identical(PakfireRepo repo1, PakfireRepo repo2);
 int pakfire_repo_cmp(PakfireRepo repo1, PakfireRepo repo2);
 int pakfire_repo_count(PakfireRepo repo);
index 6febc12d6cf304132c01debce3a2e06d879c42d5..eda17deb5a660e15d39dbbb0c1519d2285146061 100644 (file)
@@ -45,8 +45,6 @@ PakfireRequest pakfire_request_create(Pakfire pakfire);
 PakfireRequest pakfire_request_ref(PakfireRequest request);
 PakfireRequest pakfire_request_unref(PakfireRequest request);
 
-PakfirePool pakfire_request_get_pool(PakfireRequest request);
-
 int pakfire_request_solve(PakfireRequest request, int flags);
 PakfireProblem pakfire_request_get_problems(PakfireRequest request);
 PakfireTransaction pakfire_request_get_transaction(PakfireRequest request);
index 0ac7119c3725a2ef7fc488f508621a072a4b67e6..ae766b2a688849a346045e51d8af6c782aa76bf7 100644 (file)
@@ -30,7 +30,6 @@ PakfireTransaction pakfire_transaction_ref(PakfireTransaction transaction);
 PakfireTransaction pakfire_transaction_unref(PakfireTransaction transaction);
 
 Pakfire pakfire_transaction_get_pakfire(PakfireTransaction transaction);
-PakfirePool pakfire_transaction_get_pool(PakfireTransaction transaction);
 size_t pakfire_transaction_count(PakfireTransaction transaction);
 
 ssize_t pakfire_transaction_installsizechange(PakfireTransaction transaction);
index 2ac08149a86d6d0d1e694c1a79e531da0891bd2e..e7f57680fd8fc1d13308ea5b307deb8a519e66b0 100644 (file)
@@ -31,7 +31,6 @@ typedef struct _PakfireFilter* PakfireFilter;
 typedef struct _PakfireKey* PakfireKey;
 typedef struct _PakfirePackage* PakfirePackage;
 typedef struct _PakfirePackageList* PakfirePackageList;
-typedef struct _PakfirePool* PakfirePool;
 typedef struct _PakfireProblem* PakfireProblem;
 typedef struct _PakfireRelation* PakfireRelation;
 typedef struct _PakfireRelationList* PakfireRelationList;
index c9ad4d3e9bff2227badebdf29324ecdacf9963e5..901fd9f99eaf07450910fc33967984f2a296e2d2 100644 (file)
@@ -205,11 +205,6 @@ global:
        pakfire_packagelist_sort;
        pakfire_packagelist_unref;
 
-       # pool
-       pakfire_pool_create;
-       pakfire_pool_ref;
-       pakfire_pool_unref;
-
        # problem
        pakfire_problem_append;
        pakfire_problem_create;
index c7b31baf065fc4fedfe052ddc6ee91cc6588e6ef..2a0d55eb9ab42d6931658bbe372dc8e513ea3962 100644 (file)
@@ -36,7 +36,6 @@
 #include <pakfire/logging.h>
 #include <pakfire/package.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/relation.h>
 #include <pakfire/relationlist.h>
@@ -52,12 +51,7 @@ struct _PakfirePackage {
 };
 
 static Pool* pakfire_package_get_solv_pool(PakfirePackage pkg) {
-       PakfirePool pool = pakfire_get_pool(pkg->pakfire);
-
-    Pool* p = pakfire_pool_get_solv_pool(pool);
-       pakfire_pool_unref(pool);
-
-       return p;
+       return pakfire_get_solv_pool(pkg->pakfire);
 }
 
 static void pakfire_package_add_self_provides(Pakfire pakfire, PakfirePackage pkg, const char* name, const char* evr) {
index a6d7867924d96ef6dae81684c6354b8d7e193086..75d9186b3d27bb85fd646287deb060a076e558d1 100644 (file)
@@ -122,10 +122,9 @@ PAKFIRE_EXPORT void pakfire_packagelist_push_if_not_exists(PakfirePackageList li
 }
 
 PAKFIRE_EXPORT PakfirePackageList pakfire_packagelist_from_queue(Pakfire pakfire, Queue* q) {
-       PakfirePool _pool = pakfire_get_pool(pakfire);
        PakfirePackageList list = pakfire_packagelist_create();
 
-       Pool* pool = pakfire_pool_get_solv_pool(_pool);
+       Pool* pool = pakfire_get_solv_pool(pakfire);
        Id p, pp;
        for (int i = 0; i < q->count; i += 2) {
                FOR_JOB_SELECT(p, pp, q->elements[i], q->elements[i + 1]) {
@@ -136,7 +135,5 @@ PAKFIRE_EXPORT PakfirePackageList pakfire_packagelist_from_queue(Pakfire pakfire
                }
        }
 
-       pakfire_pool_unref(_pool);
-
        return list;
 }
index a7cb55927a6c3036511949e358787251c88e5517..730d06eb3116bf2f88b175ccc178955dd58fed4f 100644 (file)
@@ -35,7 +35,6 @@
 #include <pakfire/package.h>
 #include <pakfire/packagelist.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/repo.h>
 #include <pakfire/system.h>
@@ -48,7 +47,6 @@ struct _Pakfire {
        char* arch;
 
        // Pool stuff
-       PakfirePool _pool;
        Pool* pool;
        int pool_ready;
        Queue installonly;
@@ -82,7 +80,6 @@ PAKFIRE_EXPORT Pakfire pakfire_create(const char* path, const char* arch) {
                DEBUG("  path = %s\n", pakfire_get_path(pakfire));
 
                // Initialize the pool
-               pakfire->_pool = pakfire_pool_create(pakfire);
                pakfire->pool = pool_create();
 
                // Set architecture of the pool
@@ -121,7 +118,6 @@ PAKFIRE_EXPORT Pakfire pakfire_unref(Pakfire pakfire) {
        if (--pakfire->nrefs > 0)
                return pakfire;
 
-       pakfire_pool_unref(pakfire->_pool);
        pakfire_pool_free_repos(pakfire->pool);
        pool_free(pakfire->pool);
        queue_free(&pakfire->installonly);
@@ -145,10 +141,6 @@ PAKFIRE_EXPORT const char* pakfire_get_arch(Pakfire pakfire) {
        return pakfire->arch;
 }
 
-PAKFIRE_EXPORT PakfirePool pakfire_get_pool(Pakfire pakfire) {
-       return pakfire_pool_ref(pakfire->_pool);
-}
-
 PAKFIRE_EXPORT int pakfire_version_compare(Pakfire pakfire, const char* evr1, const char* evr2) {
        return pool_evrcmp_str(pakfire->pool, evr1, evr2, EVRCMP_COMPARE);
 }
diff --git a/src/libpakfire/pool.c b/src/libpakfire/pool.c
deleted file mode 100644 (file)
index a86212d..0000000
+++ /dev/null
@@ -1,82 +0,0 @@
-/*#############################################################################
-#                                                                             #
-# Pakfire - The IPFire package management system                              #
-# Copyright (C) 2013 Pakfire development team                                 #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-#############################################################################*/
-
-#include <assert.h>
-
-#include <solv/pool.h>
-#include <solv/queue.h>
-#include <solv/repo.h>
-
-#include <pakfire/logging.h>
-#include <pakfire/package.h>
-#include <pakfire/packagelist.h>
-#include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
-#include <pakfire/private.h>
-#include <pakfire/repo.h>
-#include <pakfire/types.h>
-#include <pakfire/util.h>
-
-
-// This is just being left here for compatibility
-struct _PakfirePool {
-       Pakfire pakfire;
-       int nrefs;
-};
-
-PAKFIRE_EXPORT PakfirePool pakfire_pool_create(Pakfire pakfire) {
-       PakfirePool pool = pakfire_calloc(1, sizeof(*pool));
-       if (pool) {
-               DEBUG("Allocated Pool at %p\n", pool);
-               pool->nrefs = 1;
-
-               pool->pakfire = pakfire_ref(pakfire);
-       }
-
-       return pool;
-}
-
-static void pakfire_pool_free(PakfirePool pool) {
-       pakfire_unref(pool->pakfire);
-       pakfire_free(pool);
-
-       DEBUG("Released Pool at %p\n", pool);
-}
-
-PAKFIRE_EXPORT PakfirePool pakfire_pool_ref(PakfirePool pool) {
-       ++pool->nrefs;
-
-       return pool;
-}
-
-PAKFIRE_EXPORT PakfirePool pakfire_pool_unref(PakfirePool pool) {
-       if (!pool)
-               return NULL;
-
-       if (--pool->nrefs > 0)
-               return pool;
-
-       pakfire_pool_free(pool);
-       return NULL;
-}
-
-Pool* pakfire_pool_get_solv_pool(PakfirePool pool) {
-       return pakfire_get_solv_pool(pool->pakfire);
-}
index 0955e216bb5e979f845c69fe04c97069dd0f4de2..49dda85c572c9268bdbf01db07479ace067f0fd5 100644 (file)
@@ -27,7 +27,6 @@
 #include <pakfire/logging.h>
 #include <pakfire/packagelist.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/relation.h>
 #include <pakfire/types.h>
index 6b48ddc51cb6c026e62bf9f32acb076f822c5791..0f2d944a216b922a471088671e76e2300e874699 100644 (file)
@@ -23,7 +23,6 @@
 
 #include <pakfire/logging.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/relation.h>
 #include <pakfire/relationlist.h>
index 0220fc089ebe71491b00eb5ec793c3c39df10f45..4973f08795a87ecdc2f216cdc7b6778689d0ecb6 100644 (file)
@@ -34,7 +34,6 @@
 #include <pakfire/logging.h>
 #include <pakfire/package.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/repo.h>
 #include <pakfire/types.h>
@@ -62,11 +61,10 @@ static Repo* get_repo_by_name(Pool* pool, const char* name) {
        return NULL;
 }
 
-static PakfireRepo get_pakfire_repo_by_name(PakfirePool pool, const char* name) {
-       Pool* p = pakfire_pool_get_solv_pool(pool);
-
-       Repo* repo = get_repo_by_name(p, name);
+static PakfireRepo get_pakfire_repo_by_name(Pakfire pakfire, const char* name) {
+       Pool* pool = pakfire_get_solv_pool(pakfire);
 
+       Repo* repo = get_repo_by_name(pool, name);
        if (repo)
                return repo->appdata;
 
@@ -74,23 +72,17 @@ static PakfireRepo get_pakfire_repo_by_name(PakfirePool pool, const char* name)
 }
 
 PAKFIRE_EXPORT PakfireRepo pakfire_repo_create(Pakfire pakfire, const char* name) {
-       PakfirePool pool = pakfire_get_pool(pakfire);
-
-       PakfireRepo repo = get_pakfire_repo_by_name(pool, name);
+       PakfireRepo repo = get_pakfire_repo_by_name(pakfire, name);
        if (repo) {
                repo->nrefs++;
-
-               pakfire_pool_unref(pool);
-
                return repo;
        }
 
-       Pool* p = pakfire_pool_get_solv_pool(pool);
-       pakfire_pool_unref(pool);
+       Pool* pool = pakfire_get_solv_pool(pakfire);
 
-       Repo* r = get_repo_by_name(p, name);
+       Repo* r = get_repo_by_name(pool, name);
        if (!r)
-               r = repo_create(p, name);
+               r = repo_create(pool, name);
 
        return pakfire_repo_create_from_repo(pakfire, r);
 }
@@ -150,19 +142,6 @@ Repodata* pakfire_repo_get_repodata(PakfireRepo repo) {
        return repo->filelist;
 }
 
-PAKFIRE_EXPORT PakfirePool pakfire_repo_get_pool(PakfireRepo repo) {
-       return pakfire_get_pool(repo->pakfire);
-}
-
-static Pool* pakfire_repo_get_solv_pool(PakfireRepo repo) {
-       PakfirePool pool = pakfire_repo_get_pool(repo);
-
-       Pool* p = pakfire_pool_get_solv_pool(pool);
-       pakfire_pool_unref(pool);
-
-       return p;
-}
-
 PAKFIRE_EXPORT int pakfire_repo_identical(PakfireRepo repo1, PakfireRepo repo2) {
        Repo* r1 = repo1->repo;
        Repo* r2 = repo2->repo;
@@ -184,7 +163,7 @@ PAKFIRE_EXPORT int pakfire_repo_cmp(PakfireRepo repo1, PakfireRepo repo2) {
 }
 
 PAKFIRE_EXPORT int pakfire_repo_count(PakfireRepo repo) {
-       Pool* pool = pakfire_repo_get_solv_pool(repo);
+       Pool* pool = pakfire_get_solv_pool(repo->pakfire);
        int cnt = 0;
 
        for (int i = 2; i < pool->nsolvables; i++) {
index 2e8d797f4c48bd9a80ea3355e47ddb4262684727..ac1024b57d1ed7275591cf12b1330b5ff88d6116 100644 (file)
@@ -90,10 +90,6 @@ PAKFIRE_EXPORT PakfireRequest pakfire_request_unref(PakfireRequest request) {
        return NULL;
 }
 
-PAKFIRE_EXPORT PakfirePool pakfire_request_get_pool(PakfireRequest request) {
-       return pakfire_get_pool(request->pakfire);
-}
-
 Solver* pakfire_request_get_solver(PakfireRequest request) {
        return request->solver;
 }
index 37da16c8b79da861da40cc6b83557fdd6696ff5f..d185b250b6b36843af47688510739ce9683e1e40 100644 (file)
@@ -30,7 +30,6 @@
 #include <pakfire/package.h>
 #include <pakfire/packagelist.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/selector.h>
 #include <pakfire/types.h>
index 1aa7a0579950b05d0cb6d2ded8acbae3c9e0f08e..66e8f140464718ad5ca9d39941cc2666a1dd9094 100644 (file)
@@ -27,7 +27,6 @@
 #include <pakfire/logging.h>
 #include <pakfire/package.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/repo.h>
 #include <pakfire/step.h>
index 81a101302714dc2a3140ecea835900840822c583..249e6d6067a4a87706c5805587ecc80477038600 100644 (file)
@@ -26,7 +26,6 @@
 #include <pakfire/package.h>
 #include <pakfire/packagelist.h>
 #include <pakfire/pakfire.h>
-#include <pakfire/pool.h>
 #include <pakfire/private.h>
 #include <pakfire/repo.h>
 #include <pakfire/step.h>
@@ -106,10 +105,6 @@ PAKFIRE_EXPORT Pakfire pakfire_transaction_get_pakfire(PakfireTransaction transa
        return pakfire_ref(transaction->pakfire);
 }
 
-PAKFIRE_EXPORT PakfirePool pakfire_transaction_get_pool(PakfireTransaction transaction) {
-       return pakfire_get_pool(transaction->pakfire);
-}
-
 Transaction* pakfire_transaction_get_transaction(PakfireTransaction transaction) {
        return transaction->transaction;
 }
index e4bf7575148482675468d785ebcbe17354a543d4..daeb099abbc58358cedab6163e330c28170c2fd1 100644 (file)
@@ -59,7 +59,6 @@ class Pakfire(_pakfire.Pakfire):
                # Load configuration
                self.config = config or Config("general.conf")
 
-               self.pool = _pakfire.Pool(self)
                self.cache_path = cache_path or \
                        os.path.join(CACHE_DIR, self.distro.sname, self.distro.release)
 
@@ -181,7 +180,7 @@ class PakfireContext(object):
                                        pkgs.append(pkg)
 
                        else:
-                               pkgs += self.pakfire.pool.whatprovides(pattern, name_only=True)
+                               pkgs += self.pakfire.whatprovides(pattern, name_only=True)
 
                return sorted(pkgs)
 
@@ -189,7 +188,7 @@ class PakfireContext(object):
                pkgs = []
 
                for pattern in patterns:
-                       for pkg in self.pakfire.pool.whatprovides(self, pattern):
+                       for pkg in self.pakfire.whatprovides(self, pattern):
                                if pkg in pkgs:
                                        continue
 
@@ -198,7 +197,7 @@ class PakfireContext(object):
                return sorted(pkgs)
 
        def search(self, pattern):
-               return self.pakfire.pool.search(pattern)
+               return self.pakfire.search(pattern)
 
        # Transactions
 
@@ -208,7 +207,7 @@ class PakfireContext(object):
                # XXX handle files and URLs
 
                for req in requires:
-                       relation = _pakfire.Relation(self.pakfire.pool, req)
+                       relation = _pakfire.Relation(self.pakfire, req)
                        request.install(relation)
 
                return request.solve(**kwargs)
@@ -223,7 +222,7 @@ class PakfireContext(object):
                request = _pakfire.Request(self.pakfire)
 
                for pkg in pkgs:
-                       relation = _pakfire.Relation(self.pakfire.pool, pkg)
+                       relation = _pakfire.Relation(self.pakfire, pkg)
                        request.erase(relation)
 
                return request.solve(**kwargs)
@@ -233,7 +232,7 @@ class PakfireContext(object):
 
                # Add all packages that should be updated to the request
                for req in reqs or []:
-                       relation = _pakfire.Relation(self.pakfire.pool, req)
+                       relation = _pakfire.Relation(self.pakfire, req)
                        request.upgrade(relation)
 
                # Otherwise we will try to upgrade everything
@@ -242,7 +241,7 @@ class PakfireContext(object):
 
                # Exclude packages that should not be updated
                for exclude in excludes or []:
-                       relation = _pakfire.Relation(self.pakfire.pool, exclude)
+                       relation = _pakfire.Relation(self.pakfire, exclude)
                        request.lock(relation)
 
                return request.solve(**kwargs)
@@ -254,7 +253,7 @@ class PakfireContext(object):
                        logger = logging.getLogger("pakfire")
 
                # Create a new request.
-               request = self.pakfire.pool.create_request()
+               request = self.pakfire.create_request()
 
                # Fill request.
                for pattern in pkgs:
@@ -272,11 +271,11 @@ class PakfireContext(object):
                        if best is None:
                                logger.warning(_("\"%s\" package does not seem to be installed.") % pattern)
                        else:
-                               rel = self.pakfire.pool.create_relation("%s < %s" % (best.name, best.friendly_version))
+                               rel = self.pakfire.create_relation("%s < %s" % (best.name, best.friendly_version))
                                request.install(rel)
 
                # Solve the request.
-               solver = self.pakfire.pool.solve(request, allow_downgrade=True, **kwargs)
+               solver = self.pakfire.solve(request, allow_downgrade=True, **kwargs)
                assert solver.status is True
 
                # Create the transaction.
index de2b9b621e3cd97e89d30eb5ae81b374f61eb011..b4bef3f7a3856dd477b277aa86761b5f9d43fa28 100644 (file)
@@ -53,8 +53,7 @@ class Package(object):
                        #log.debug("%s is equal to %s by UUID" % (self, other))
                        return 0
 
-               ret = util.version_compare(self.pakfire.pool,
-                       self.friendly_version, other.friendly_version)
+               ret = self.pakfire.version_compare(self.friendly_version, other.friendly_version)
 
                # XXX this is to move packages that have been built a while ago and
                # do not have all the meta information that they won't be evaluated
index 1cbcb1ed80e5e7ff771a56dcb58becaa6fd066a7..54899e8c623beb13287d2acd0749b3e49dbb3ffe 100644 (file)
@@ -88,10 +88,6 @@ class Repositories(object):
        def distro(self):
                return self.pakfire.distro
 
-       @property
-       def pool(self):
-               return self.pakfire.pool
-
        def load_configuration(self, *paths):
                c = config.Config()
 
@@ -191,7 +187,7 @@ class Repositories(object):
                                repo.enabled = False
 
        def whatprovides(self, *args, **kwargs):
-               return self.pool.whatprovides(self.pakfire, *args, **kwargs)
+               return self.pakfire.whatprovides(*args, **kwargs)
 
        def clean(self):
                log.info("Cleaning up all repository caches...")
index 1b7fe27e97cfed037e545fdbe02e89ede1ff3aa7..85fd6ce64137e8975e8feb56bf0821535551718d 100644 (file)
@@ -35,7 +35,7 @@ from .constants import *
 from .i18n import _
 
 # Import binary version of version_compare and capability functions
-from ._pakfire import version_compare, get_capabilities, set_capabilities, personality
+from ._pakfire import get_capabilities, set_capabilities, personality
 
 def cli_is_interactive():
        """