]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
interconnect: icc-clk: check return values of devm_kasprintf()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 2 Dec 2024 16:57:23 +0000 (17:57 +0100)
committerGeorgi Djakov <djakov@kernel.org>
Tue, 17 Dec 2024 12:03:34 +0000 (14:03 +0200)
devm_kasprintf() can fail and return NULL, add missing return value
checks.

Fixes: 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241202165723.17292-1-brgl@bgdev.pl
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/icc-clk.c

index b956e4050f38156bbc7732cafcec4129aa78e514..88f311c110207757f0609e5cec7d377a91133c6d 100644 (file)
@@ -116,6 +116,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
                }
 
                node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_master", data[i].name);
+               if (!node->name) {
+                       ret = -ENOMEM;
+                       goto err;
+               }
+
                node->data = &qp->clocks[i];
                icc_node_add(node, provider);
                /* link to the next node, slave */
@@ -129,6 +134,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
                }
 
                node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_slave", data[i].name);
+               if (!node->name) {
+                       ret = -ENOMEM;
+                       goto err;
+               }
+
                /* no data for slave node */
                icc_node_add(node, provider);
                onecell->nodes[j++] = node;