]> git.ipfire.org Git - thirdparty/git.git/commitdiff
show-branch: note about its object flags usage
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>
Sat, 19 May 2018 05:28:28 +0000 (07:28 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 May 2018 05:07:20 +0000 (14:07 +0900)
This is another candidate for commit-slab. Keep Junio's observation in
code so we can search it later on when somebody wants to improve the
code.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/show-branch.c
object.h

index 29d15d16d250af20a20b0f38a16663e4ec664923..f2e985c00abd2e6f7aa1eaa1c9368f4c3ada60ab 100644 (file)
@@ -22,6 +22,11 @@ static int showbranch_use_color = -1;
 
 static struct argv_array default_args = ARGV_ARRAY_INIT;
 
+/*
+ * TODO: convert this use of commit->object.flags to commit-slab
+ * instead to store a pointer to ref name directly. Then use the same
+ * UNINTERESTING definition from revision.h here.
+ */
 #define UNINTERESTING  01
 
 #define REV_SHIFT       2
index b8e70e55190bb918a523af0e45fac626b0290fdc..caf36529f3698036504ee789a62a7cf5496e4eba 100644 (file)
--- a/object.h
+++ b/object.h
@@ -43,6 +43,7 @@ struct object_array {
  * builtin/index-pack.c:                                     2021
  * builtin/pack-objects.c:                                   20
  * builtin/reflog.c:                   10--12
+ * builtin/show-branch.c:    0-------------------------------------------26
  * builtin/unpack-objects.c:                                 2021
  */
 #define FLAG_BITS  27