]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 5022: Reconfigure kills Coordinator in SMP+ufs configurations (#556)
authorDrDaveD <2129743+DrDaveD@users.noreply.github.com>
Fri, 21 Feb 2020 05:12:04 +0000 (05:12 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Thu, 19 Mar 2020 10:49:01 +0000 (23:49 +1300)
In these unsupported SMP+ufs configurations, depending on the deployment
specifics, the Coordinator process could exit due to swap state file
opening errors:

    kid11| FATAL: UFSSwapDir::openLog: Failed to open swap log.

src/fs/ufs/UFSSwapDir.cc

index 142717ea573925c964e3782744c7bb824cafd96b..0718433f46aa902f069505e42d9576c6ac419e24 100644 (file)
@@ -728,6 +728,9 @@ Fs::Ufs::UFSSwapDir::logFile(char const *ext) const
 void
 Fs::Ufs::UFSSwapDir::openLog()
 {
+    if (!IamWorkerProcess())
+        return;
+
     assert(NumberOfUFSDirs || !UFSDirToGlobalDirMapping);
     ++NumberOfUFSDirs;
     assert(NumberOfUFSDirs <= Config.cacheSwap.n_configured);