platform/x86/amd/pmf: Return a status code only as a constant in two functions

Return a status code without storing it in an intermediate variable.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/0d0c4876-37d7-4bee-912e-56324495454f@web.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c
index eb367e38c5abd2b773531b294791b22f8dcea742..f2eb07ef855afbb09da5b4c0a24650900b787652 100644 (file)
--- a/drivers/platform/x86/amd/pmf/acpi.c
+++ b/drivers/platform/x86/amd/pmf/acpi.c
@@ -111,7 +111,6 @@ int apmf_os_power_slider_update(struct amd_pmf_dev *pdev, u8 event)
        struct os_power_slider args;
        struct acpi_buffer params;
        union acpi_object *info;
-       int err = 0;
 
        args.size = sizeof(args);
        args.slider_event = event;
@@ -121,10 +120,10 @@ int apmf_os_power_slider_update(struct amd_pmf_dev *pdev, u8 event)
 
        info = apmf_if_call(pdev, APMF_FUNC_OS_POWER_SLIDER_UPDATE, &params);
        if (!info)
-               err = -EIO;
+               return -EIO;
 
        kfree(info);
-       return err;
+       return 0;
 }
 
 static void apmf_sbios_heartbeat_notify(struct work_struct *work)
@@ -146,7 +145,6 @@ int apmf_update_fan_idx(struct amd_pmf_dev *pdev, bool manual, u32 idx)
        union acpi_object *info;
        struct apmf_fan_idx args;
        struct acpi_buffer params;
-       int err = 0;
 
        args.size = sizeof(args);
        args.fan_ctl_mode = manual;
@@ -156,14 +154,11 @@ int apmf_update_fan_idx(struct amd_pmf_dev *pdev, bool manual, u32 idx)
        params.pointer = (void *)&args;
 
        info = apmf_if_call(pdev, APMF_FUNC_SET_FAN_IDX, &params);
-       if (!info) {
-               err = -EIO;
-               goto out;
-       }
+       if (!info)
+               return -EIO;
 
-out:
        kfree(info);
-       return err;
+       return 0;
 }
 
 int apmf_get_auto_mode_def(struct amd_pmf_dev *pdev, struct apmf_auto_mode *data)