]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ravb: Disable IP header TX checksum offloading
authorPaul Barker <paul.barker.ct@bp.renesas.com>
Tue, 15 Oct 2024 13:36:30 +0000 (14:36 +0100)
committerAndrew Lunn <andrew@lunn.ch>
Fri, 18 Oct 2024 02:24:24 +0000 (21:24 -0500)
For IPv4 packets, the header checksum will always be calculated in software
in the TX path (Documentation/networking/checksum-offloads.rst says "No
offloading of the IP header checksum is performed; it is always done in
software.") so there is no advantage in asking the hardware to also
calculate this checksum.

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
drivers/net/ethernet/renesas/ravb.h

index 98496aa39f3d9876fc43fc690b38eee8cb1e4fe5..a5b4f4fe77b1e7ae283a786b95a435c805e12402 100644 (file)
@@ -998,7 +998,7 @@ enum CSR1_BIT {
        CSR1_TDHD       = 0x08000000,
 };
 
-#define CSR1_CSUM_ENABLE (CSR1_TIP4 | CSR1_TTCP4 | CSR1_TUDP4)
+#define CSR1_CSUM_ENABLE (CSR1_TTCP4 | CSR1_TUDP4)
 
 enum CSR2_BIT {
        CSR2_RIP4       = 0x00000001,