]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable...
authorJeremy Allison <jra@samba.org>
Fri, 2 Dec 2011 18:55:40 +0000 (10:55 -0800)
committerKarolin Seeger <kseeger@samba.org>
Mon, 23 Jan 2012 20:28:58 +0000 (21:28 +0100)
If referring to an fsp sbuf can be left as an uninitialized variable,
causing the 'is_directory' variable to be false when it should be true.
(cherry picked from commit 16c0d52842386fc2ebf975166b57b888d36796c5)

source3/modules/vfs_acl_common.c

index 81c734a535d7f49927571c593356023771eec687..f82f0319c1a7784a991e2e2a21448d300f0e6a6b 100644 (file)
@@ -378,7 +378,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
                                return map_nt_error_from_unix(errno);
                        }
                }
-               is_directory = S_ISDIR(sbuf.st_ex_mode);
+               is_directory = S_ISDIR(psbuf->st_ex_mode);
 
                if (ignore_file_system_acl) {
                        TALLOC_FREE(pdesc_next);