]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
srcu: Remove redundant GP sequence checks in srcu_funnel_gp_start
authorFeng Lee <379943137@qq.com>
Tue, 19 Nov 2024 07:29:49 +0000 (15:29 +0800)
committerUladzislau Rezki (Sony) <urezki@gmail.com>
Sat, 14 Dec 2024 16:13:24 +0000 (17:13 +0100)
We will perform GP sequence checking at the beginning of srcu_gp_start,
thus making it safe to remove duplicate GP sequence checks prior to
calling srcu_gp_start.

Signed-off-by: Feng Lee <379943137@qq.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
kernel/rcu/srcutree.c

index 26ef58b481aaea6055047875dbe021cea343a9f3..b83c74c4dcc0d99b270c6abd5dd58cc6fe57135a 100644 (file)
@@ -1077,7 +1077,6 @@ static void srcu_funnel_gp_start(struct srcu_struct *ssp, struct srcu_data *sdp,
        /* If grace period not already in progress, start it. */
        if (!WARN_ON_ONCE(rcu_seq_done(&sup->srcu_gp_seq, s)) &&
            rcu_seq_state(sup->srcu_gp_seq) == SRCU_STATE_IDLE) {
-               WARN_ON_ONCE(ULONG_CMP_GE(sup->srcu_gp_seq, sup->srcu_gp_seq_needed));
                srcu_gp_start(ssp);
 
                // And how can that list_add() in the "else" clause