]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: Init cpufreq only for present CPUs
authorJacky Bai <ping.bai@nxp.com>
Thu, 13 Mar 2025 01:39:28 +0000 (09:39 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 17 Mar 2025 05:59:18 +0000 (11:29 +0530)
for_each_possible_cpu() is currently used to initialize cpufreq.
However, in cpu_dev_register_generic(), for_each_present_cpu()
is used to register CPU devices which means the CPU devices are
only registered for present CPUs and not all possible CPUs.

With nosmp or maxcpus=0, only the boot CPU is present, lead
to the cpufreq probe failure or defer probe due to no cpu device
available for not present CPUs.

Change for_each_possible_cpu() to for_each_present_cpu() in the
above cpufreq drivers to ensure it only registers cpufreq for
CPUs that are actually present.

Fixes: b0c69e1214bc ("drivers: base: Use present CPUs in GENERIC_CPU_DEVICES")
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/armada-8k-cpufreq.c
drivers/cpufreq/cpufreq-dt.c
drivers/cpufreq/mediatek-cpufreq-hw.c
drivers/cpufreq/mediatek-cpufreq.c
drivers/cpufreq/mvebu-cpufreq.c
drivers/cpufreq/qcom-cpufreq-hw.c
drivers/cpufreq/qcom-cpufreq-nvmem.c
drivers/cpufreq/scmi-cpufreq.c
drivers/cpufreq/scpi-cpufreq.c
drivers/cpufreq/sun50i-cpufreq-nvmem.c
drivers/cpufreq/virtual-cpufreq.c

index 7a979db81f0982851e04b9b92dbcb77de5c261e7..5a3545bd0d8d201e9be1bd6b836f2cc48e302021 100644 (file)
@@ -47,7 +47,7 @@ static void __init armada_8k_get_sharing_cpus(struct clk *cur_clk,
 {
        int cpu;
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                struct device *cpu_dev;
                struct clk *clk;
 
index 778916f89a51bf5f6201d68a21ab9957ede33246..e80dd982a3e23f6e678d691daba2d8bfda28d93c 100644 (file)
@@ -283,7 +283,7 @@ static int dt_cpufreq_probe(struct platform_device *pdev)
        int ret, cpu;
 
        /* Request resources early so we can return in case of -EPROBE_DEFER */
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                ret = dt_cpufreq_early_init(&pdev->dev, cpu);
                if (ret)
                        goto err;
index aa209f5527dc5f1dc0b5c0f2c9bfaa7afaa8830d..74f1b4c796e4cc9ebccf50dd4e165a1eba03136a 100644 (file)
@@ -303,7 +303,7 @@ static int mtk_cpufreq_hw_driver_probe(struct platform_device *pdev)
        struct regulator *cpu_reg;
 
        /* Make sure that all CPU supplies are available before proceeding. */
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                cpu_dev = get_cpu_device(cpu);
                if (!cpu_dev)
                        return dev_err_probe(&pdev->dev, -EPROBE_DEFER,
index 2656b88db378b2ab22cd3945d8eba5872a025941..f3f02c4b6888b4910e4ff496f5ddf0d682f7d976 100644 (file)
@@ -631,7 +631,7 @@ static int mtk_cpufreq_probe(struct platform_device *pdev)
                return dev_err_probe(&pdev->dev, -ENODEV,
                                     "failed to get mtk cpufreq platform data\n");
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                info = mtk_cpu_dvfs_info_lookup(cpu);
                if (info)
                        continue;
index 7f3cfe668f307cde78084d69ceb80c2fa571c9d5..2aad4c04673cc50e22d83aba6da3910c69557700 100644 (file)
@@ -56,7 +56,7 @@ static int __init armada_xp_pmsu_cpufreq_init(void)
         * it), and registers the clock notifier that will take care
         * of doing the PMSU part of a frequency transition.
         */
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                struct device *cpu_dev;
                struct clk *clk;
                int ret;
index 4b3b3dbc7d38b6b0a1b05aff3bb8e25eeffeba34..8422704a3b10fcbea8df7e3f725d675724101a42 100644 (file)
@@ -306,7 +306,7 @@ static void qcom_get_related_cpus(int index, struct cpumask *m)
        struct of_phandle_args args;
        int cpu, ret;
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                cpu_np = of_cpu_device_node_get(cpu);
                if (!cpu_np)
                        continue;
index 3a8ed723a23e52d46d279d22a9e3fbfcd3f0479b..54f8117103c850ff8a7d1a8cd408b7117939cb0d 100644 (file)
@@ -489,7 +489,7 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
                nvmem_cell_put(speedbin_nvmem);
        }
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                struct dev_pm_opp_config config = {
                        .supported_hw = NULL,
                };
@@ -543,7 +543,7 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
        dev_err(cpu_dev, "Failed to register platform device\n");
 
 free_opp:
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                dev_pm_domain_detach_list(drv->cpus[cpu].pd_list);
                dev_pm_opp_clear_config(drv->cpus[cpu].opp_token);
        }
@@ -557,7 +557,7 @@ static void qcom_cpufreq_remove(struct platform_device *pdev)
 
        platform_device_unregister(cpufreq_dt_pdev);
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                dev_pm_domain_detach_list(drv->cpus[cpu].pd_list);
                dev_pm_opp_clear_config(drv->cpus[cpu].opp_token);
        }
@@ -568,7 +568,7 @@ static int qcom_cpufreq_suspend(struct device *dev)
        struct qcom_cpufreq_drv *drv = dev_get_drvdata(dev);
        unsigned int cpu;
 
-       for_each_possible_cpu(cpu)
+       for_each_present_cpu(cpu)
                qcom_cpufreq_suspend_pd_devs(drv, cpu);
 
        return 0;
index ff289778979739c2525f9cd31db9e79c2a71b334..c310aeebc8f36b76b779a4c555f4f7ce9c165108 100644 (file)
@@ -104,7 +104,7 @@ scmi_get_sharing_cpus(struct device *cpu_dev, int domain,
        int cpu, tdomain;
        struct device *tcpu_dev;
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                if (cpu == cpu_dev->id)
                        continue;
 
index 048dc43a999738e98ca877fe56b73c87a9d98ac3..17cda84f00dfb9458889ca750e932944c0bdfe37 100644 (file)
@@ -65,7 +65,7 @@ scpi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
        if (domain < 0)
                return domain;
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                if (cpu == cpu_dev->id)
                        continue;
 
index 17d6a149f580dccf7e348d433e9790f091279963..47d6840b3489942b5e83f81cea281efa6647cd04 100644 (file)
@@ -262,7 +262,7 @@ static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
        snprintf(name, sizeof(name), "speed%d", speed);
        config.prop_name = name;
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                struct device *cpu_dev = get_cpu_device(cpu);
 
                if (!cpu_dev) {
@@ -288,7 +288,7 @@ static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
        pr_err("Failed to register platform device\n");
 
 free_opp:
-       for_each_possible_cpu(cpu)
+       for_each_present_cpu(cpu)
                dev_pm_opp_clear_config(opp_tokens[cpu]);
        kfree(opp_tokens);
 
@@ -302,7 +302,7 @@ static void sun50i_cpufreq_nvmem_remove(struct platform_device *pdev)
 
        platform_device_unregister(cpufreq_dt_pdev);
 
-       for_each_possible_cpu(cpu)
+       for_each_present_cpu(cpu)
                dev_pm_opp_clear_config(opp_tokens[cpu]);
 
        kfree(opp_tokens);
index 45becb92aa4a83d2e2d7d8331af389d27bc94f1c..7dd1b0c263c7edf73de5bfb4d1b03ef12c72f5cc 100644 (file)
@@ -138,7 +138,7 @@ static int virt_cpufreq_get_sharing_cpus(struct cpufreq_policy *policy)
        cur_perf_domain = readl_relaxed(base + policy->cpu *
                                        PER_CPU_OFFSET + REG_PERF_DOMAIN_OFFSET);
 
-       for_each_possible_cpu(cpu) {
+       for_each_present_cpu(cpu) {
                cpu_dev = get_cpu_device(cpu);
                if (!cpu_dev)
                        continue;