]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: stm32-ospi: Fix an error handling path in stm32_ospi_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 18 Apr 2025 11:27:53 +0000 (13:27 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 22 Apr 2025 13:58:18 +0000 (14:58 +0100)
If an error occurs after a successful stm32_ospi_dma_setup() call, some
dma_release_channel() calls are needed to release some resources, as
already done in the remove function.

Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Link: https://patch.msgid.link/2674c8df1d05ab312826b69bfe9559f81d125a0b.1744975624.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32-ospi.c

index 668022098b1eac3628f0677e6d786e5a267346be..9ec9823409cc3dd7a396d7587cc12d34717f9ec1 100644 (file)
@@ -960,6 +960,10 @@ err_pm_resume:
 err_pm_enable:
        pm_runtime_force_suspend(ospi->dev);
        mutex_destroy(&ospi->lock);
+       if (ospi->dma_chtx)
+               dma_release_channel(ospi->dma_chtx);
+       if (ospi->dma_chrx)
+               dma_release_channel(ospi->dma_chrx);
 
        return ret;
 }