]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
io_uring/cmd_net: fix wrong argument types for skb_queue_splice()
authorJens Axboe <axboe@kernel.dk>
Thu, 20 Nov 2025 18:40:15 +0000 (11:40 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 20 Nov 2025 18:40:15 +0000 (11:40 -0700)
If timestamp retriving needs to be retried and the local list of
SKB's already has entries, then it's spliced back into the socket
queue. However, the arguments for the splice helper are transposed,
causing exactly the wrong direction of splicing into the on-stack
list. Fix that up.

Cc: stable@vger.kernel.org
Reported-by: Google Big Sleep <big-sleep-vuln-reports+bigsleep-462435176@google.com>
Fixes: 9e4ed359b8ef ("io_uring/netcmd: add tx timestamping cmd support")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/cmd_net.c

index 27a09aa4c9d0b41f797d165d99c7c8ca06c4ec9e..3b75931bd569526dfc5e49a7dafc00a370144c48 100644 (file)
@@ -127,7 +127,7 @@ static int io_uring_cmd_timestamp(struct socket *sock,
 
        if (!unlikely(skb_queue_empty(&list))) {
                scoped_guard(spinlock_irqsave, &q->lock)
-                       skb_queue_splice(q, &list);
+                       skb_queue_splice(&list, q);
        }
        return -EAGAIN;
 }