]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
tst-resolv-invalid-cname.c: Explicitly cast 192 and 168 to char
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 16 Dec 2024 21:54:52 +0000 (05:54 +0800)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 17 Dec 2024 17:25:55 +0000 (01:25 +0800)
Explicitly cast 192 and 168 to char to silence Clang error:

tst-resolv-invalid-cname.c:313:17: error: implicit conversion from 'int' to 'char' changes value from 192 to -64 [-Werror,-Wconstant-conversion]
  313 |       addr[0] = 192;
      |               ~ ^~~
tst-resolv-invalid-cname.c:314:17: error: implicit conversion from 'int' to 'char' changes value from 168 to -88 [-Werror,-Wconstant-conversion]
  314 |       addr[1] = 168;
      |               ~ ^~~

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Sam James <sam@gentoo.org>
resolv/tst-resolv-invalid-cname.c

index 69f1c63be1439b7df828b5444890fc727c1a84d4..15ee9cb5b57a22f63b79728c98fd4b7d6b15d134 100644 (file)
@@ -310,8 +310,8 @@ check_reverse (int af, int bits, int count)
   socklen_t addrlen;
   if (af == AF_INET)
     {
-      addr[0] = 192;
-      addr[1] = 168;
+      addr[0] = (char) 192;
+      addr[1] = (char) 168;
       addr[2] = count;
       addr[3] = bits;
       addrlen = 4;