Call haveParsedReplyHeaders() before entry->replaceHttpReply().

HaveParsedReplyHeaders() sets the entry public key and various flags (at
least). ReplaceHttpReply() packs reply headers, starting swapout process.
It feels natural to adjust the entry _before_ we pack/swap it, but I may be
missing some side-effects here.

The change was necessary because we started calling checkCachable() from
swapoutPossible(). If haveParsedReplyHeaders() is not called before we swap
out checks, the entry will still have the private key and will be declared
impossible to cache.

diff --git a/src/Server.cc b/src/Server.cc
index ef6f8abdb8ec00e6ddea7a708e70e0f2fd179ac3..5baf389a1eba2416f67401f21d595e94dd8a976c 100644 (file)
--- a/src/Server.cc
+++ b/src/Server.cc
@@ -162,8 +162,8 @@ ServerStateData::setFinalReply(HttpReply *rep)
     assert(rep);
     theFinalReply = HTTPMSGLOCK(rep);
 
-    entry->replaceHttpReply(theFinalReply);
     haveParsedReplyHeaders();
+    entry->replaceHttpReply(theFinalReply);
 
     return theFinalReply;
 }