* src/copy.c (copy_internal): Add a comment saying why we prefer

mknod over mkfifo.

diff --git a/ChangeLog b/ChangeLog
index fee7654447b5846cdd09179ae6f5b93544f358fb..260955c3951ef6e9f785df86c6efd1abf2179fd6 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2006-10-21  Jim Meyering  <jim@meyering.net>
 
+       * src/copy.c (copy_internal): Add a comment saying why we prefer
+       mknod over mkfifo.
+
        Enable an fts optimization (call lstat only for directories,
        on some file system types) also with the --preserve-root option
        of chown or chgrp.

diff --git a/src/copy.c b/src/copy.c
index 3cc80945938ca5882855cfb65008b82a00ad0def..5b66b281d4f1b7998a27aebe163790f703196d05 100644 (file)
--- a/src/copy.c
+++ b/src/copy.c
@@ -1634,6 +1634,9 @@ copy_internal (char const *src_name, char const *dst_name,
     }
   else if (S_ISFIFO (src_mode))
     {
+      /* Use mknod, rather than mkfifo, because the former preserves
+        the special mode bits of a fifo on Solaris 10, while mkfifo
+        does not.  */
       if (mknod (dst_name, src_mode, 0) != 0)
        {
          error (0, errno, _("cannot create fifo %s"), quote (dst_name));