]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: SOF: pcm: Clear the susbstream pointer to NULL on close
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 5 Feb 2025 13:52:32 +0000 (15:52 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 5 Feb 2025 14:06:27 +0000 (14:06 +0000)
The spcm->stream[substream->stream].substream is set during open and was
left untouched. After the first PCM stream it will never be NULL and we
have code which checks for substream NULLity as indication if the stream is
active or not.
For the compressed cstream pointer the same has been done, this change will
correct the handling of PCM streams.

Fixes: 090349a9feba ("ASoC: SOF: Add support for compress API for stream data/offset")
Cc: stable@vger.kernel.org
Reported-by: Curtis Malainey <cujomalainey@chromium.org>
Closes: https://github.com/thesofproject/linux/pull/5214
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
Link: https://patch.msgid.link/20250205135232.19762-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/pcm.c

index 35a7462d8b69385a7565a2401f476926b37837ac..c5c6353f18ceefe24668830b6475ac296668db23 100644 (file)
@@ -511,6 +511,8 @@ static int sof_pcm_close(struct snd_soc_component *component,
                 */
        }
 
+       spcm->stream[substream->stream].substream = NULL;
+
        return 0;
 }