]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: vxlan: rename SKB_DROP_REASON_VXLAN_NO_REMOTE
authorRadu Rendec <rrendec@redhat.com>
Thu, 19 Dec 2024 16:36:05 +0000 (11:36 -0500)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 18:11:04 +0000 (10:11 -0800)
The SKB_DROP_REASON_VXLAN_NO_REMOTE skb drop reason was introduced in
the specific context of vxlan. As it turns out, there are similar cases
when a packet needs to be dropped in other parts of the network stack,
such as the bridge module.

Rename SKB_DROP_REASON_VXLAN_NO_REMOTE and give it a more generic name,
so that it can be used in other parts of the network stack. This is not
a functional change, and the numeric value of the drop reason even
remains unchanged.

Signed-off-by: Radu Rendec <rrendec@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20241219163606.717758-2-rrendec@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/vxlan/vxlan_core.c
drivers/net/vxlan/vxlan_mdb.c
include/net/dropreason-core.h

index 0c356e0a61ef01450fbe9f8ffd0d1dceab73d0a9..05c10acb2a57edef3d012b49fe9b964c6c3e818d 100644 (file)
@@ -2798,7 +2798,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
                        dev_dstats_tx_dropped(dev);
                        vxlan_vnifilter_count(vxlan, vni, NULL,
                                              VXLAN_VNI_STATS_TX_DROPS, 0);
-                       kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);
+                       kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);
                        return NETDEV_TX_OK;
                }
        }
@@ -2821,7 +2821,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
                if (fdst)
                        vxlan_xmit_one(skb, dev, vni, fdst, did_rsc);
                else
-                       kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);
+                       kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);
        }
 
        return NETDEV_TX_OK;
index 8735891ee1286bd626c0f3d8f459901d6f191f28..816ab1aa05262d9173bb1d2eeb62072cdcd7f263 100644 (file)
@@ -1712,7 +1712,7 @@ netdev_tx_t vxlan_mdb_xmit(struct vxlan_dev *vxlan,
                vxlan_xmit_one(skb, vxlan->dev, src_vni,
                               rcu_dereference(fremote->rd), false);
        else
-               kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);
+               kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);
 
        return NETDEV_TX_OK;
 }
index ead4170a1d0a9d3198876fabf453130bf11953be..6e32106d722949042a4b4d6e561f58ed91332df9 100644 (file)
        FN(VXLAN_VNI_NOT_FOUND)         \
        FN(MAC_INVALID_SOURCE)          \
        FN(VXLAN_ENTRY_EXISTS)          \
-       FN(VXLAN_NO_REMOTE)             \
+       FN(NO_TX_TARGET)                \
        FN(IP_TUNNEL_ECN)               \
        FN(TUNNEL_TXINFO)               \
        FN(LOCAL_MAC)                   \
@@ -497,8 +497,8 @@ enum skb_drop_reason {
         * entry or an entry pointing to a nexthop.
         */
        SKB_DROP_REASON_VXLAN_ENTRY_EXISTS,
-       /** @SKB_DROP_REASON_VXLAN_NO_REMOTE: no remote found for xmit */
-       SKB_DROP_REASON_VXLAN_NO_REMOTE,
+       /** @SKB_DROP_REASON_NO_TX_TARGET: no target found for xmit */
+       SKB_DROP_REASON_NO_TX_TARGET,
        /**
         * @SKB_DROP_REASON_IP_TUNNEL_ECN: skb is dropped according to
         * RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.