]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ar0521: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:33:54 +0000 (15:33 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:19 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get()
that works on both DT- and ACPI-based platforms to retrieve a reference to
the clock producer from firmware.

Acked-by: Krzysztof HaƂasa <khalasa@piap.pl>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ar0521.c

index 24873149096c1a2251a9f63623f393542eecf193..939bf590d4b2107c6669b83903028744de1c2b30 100644 (file)
@@ -1077,11 +1077,10 @@ static int ar0521_probe(struct i2c_client *client)
        }
 
        /* Get master clock (extclk) */
-       sensor->extclk = devm_clk_get(dev, "extclk");
-       if (IS_ERR(sensor->extclk)) {
-               dev_err(dev, "failed to get extclk\n");
-               return PTR_ERR(sensor->extclk);
-       }
+       sensor->extclk = devm_v4l2_sensor_clk_get(dev, "extclk");
+       if (IS_ERR(sensor->extclk))
+               return dev_err_probe(dev, PTR_ERR(sensor->extclk),
+                                    "failed to get extclk\n");
 
        sensor->extclk_freq = clk_get_rate(sensor->extclk);