]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/scheduler: signal scheduled fence when kill job
authorLin.Cao <lincao12@amd.com>
Thu, 15 May 2025 02:07:13 +0000 (10:07 +0800)
committerChristian König <christian.koenig@amd.com>
Thu, 22 May 2025 14:54:40 +0000 (16:54 +0200)
When an entity from application B is killed, drm_sched_entity_kill()
removes all jobs belonging to that entity through
drm_sched_entity_kill_jobs_work(). If application A's job depends on a
scheduled fence from application B's job, and that fence is not properly
signaled during the killing process, application A's dependency cannot be
cleared.

This leads to application A hanging indefinitely while waiting for a
dependency that will never be resolved. Fix this issue by ensuring that
scheduled fences are properly signaled when an entity is killed, allowing
dependent applications to continue execution.

Signed-off-by: Lin.Cao <lincao12@amd.com>
Reviewed-by: Philipp Stanner <phasta@kernel.org>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/r/20250515020713.1110476-1-lincao12@amd.com
drivers/gpu/drm/scheduler/sched_entity.c

index bd39db7bb2408763d0388b62c108b1702e7a1e81..e671aa241720684ec4f8d7b118f8e3d37114724c 100644 (file)
@@ -176,6 +176,7 @@ static void drm_sched_entity_kill_jobs_work(struct work_struct *wrk)
 {
        struct drm_sched_job *job = container_of(wrk, typeof(*job), work);
 
+       drm_sched_fence_scheduled(job->s_fence, NULL);
        drm_sched_fence_finished(job->s_fence, -ESRCH);
        WARN_ON(job->s_fence->parent);
        job->sched->ops->free_job(job);