]> git.ipfire.org Git - thirdparty/git.git/commitdiff
pack-bitmap: drop unused parameters from select_pseudo_merges()
authorJeff King <peff@peff.net>
Sat, 17 Aug 2024 07:29:37 +0000 (03:29 -0400)
committerJunio C Hamano <gitster@pobox.com>
Sat, 17 Aug 2024 16:44:41 +0000 (09:44 -0700)
We take the array of indexed_commits (and its length), but there's no
need. The selection is based on ref reachability, not the linearized set
of commits we're packing.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-bitmap-write.c
pseudo-merge.c
pseudo-merge.h

index 77876002347cc7e7cc6e39851b91aef7bf14d96a..9b9ca1cc3684560a4205eaba57ffe9e770d54065 100644 (file)
@@ -737,7 +737,7 @@ void bitmap_writer_select_commits(struct bitmap_writer *writer,
 
        stop_progress(&writer->progress);
 
-       select_pseudo_merges(writer, indexed_commits, indexed_commits_nr);
+       select_pseudo_merges(writer);
 }
 
 
index 1d7f5381a46360e0a3c647429b534f418c3e8756..c952a7cba9ea9e71566e0d5fd54ca73bd3fbc036 100644 (file)
@@ -425,8 +425,7 @@ static void sort_pseudo_merge_matches(struct pseudo_merge_matches *matches)
        QSORT(matches->unstable, matches->unstable_nr, commit_date_cmp);
 }
 
-void select_pseudo_merges(struct bitmap_writer *writer,
-                         struct commit **commits, size_t commits_nr)
+void select_pseudo_merges(struct bitmap_writer *writer)
 {
        struct progress *progress = NULL;
        uint32_t i;
index 3aecba772b1ceb33d3321aa4a5e5cb68e648e813..4b5febaa63e6fe5ab26b8239b8c71de3ff573456 100644 (file)
@@ -95,8 +95,7 @@ struct pseudo_merge_commit_idx {
  *
  * Optionally shows a progress meter.
  */
-void select_pseudo_merges(struct bitmap_writer *writer,
-                         struct commit **commits, size_t commits_nr);
+void select_pseudo_merges(struct bitmap_writer *writer);
 
 /*
  * Represents a serialized view of a file containing pseudo-merge(s)