]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: qat/qat_4xxx - fix off by one in uof_get_name()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 28 Sep 2024 10:05:08 +0000 (13:05 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 5 Oct 2024 05:22:06 +0000 (13:22 +0800)
The fw_objs[] array has "num_objs" elements so the > needs to be >= to
prevent an out of bounds read.

Fixes: 10484c647af6 ("crypto: qat - refactor fw config logic for 4xxx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c

index 9fd7ec53b9f3d82f356a71d6e838da9b0cd65806..bbd92c017c28edbe18a63e9359a1f2f5c7a3bb1d 100644 (file)
@@ -334,7 +334,7 @@ static const char *uof_get_name(struct adf_accel_dev *accel_dev, u32 obj_num,
        else
                id = -EINVAL;
 
-       if (id < 0 || id > num_objs)
+       if (id < 0 || id >= num_objs)
                return NULL;
 
        return fw_objs[id];