]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_hw.c: fix Coverity CIDs#13664,#13665 Resource leak
authorMarek Schimara <Marek.Schimara@bull.net>
Fri, 17 Jun 2016 08:15:31 +0000 (10:15 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

src/rrd_hw.c

index ac726be8ee6b9274a953047b6a154343783633f9..4d74c1e93339f88546b639eefb35232227f472bf 100644 (file)
@@ -262,6 +262,8 @@ int apply_smoother(
             rrd_set_error("apply smoother: SEASONAL rra doesn't have "
                           "valid dependency: %s",
                           rrd->rra_def[hw_dep_idx(rrd, rra_idx)].cf_nam);
+            free(rrd_values);
+            free(baseline);
             return -1;
         }
 
@@ -315,6 +317,7 @@ int apply_smoother(
         != (ssize_t) (sizeof(rrd_value_t) * row_length * row_count)) {
         rrd_set_error("apply_smoother: write failed to %lu", rra_start);
         free(rrd_values);
+        free(baseline);
         return -1;
     }