netlink: Avoid memleak in error path of netlink_delinearize_table()

If parsing udata fails, 'table' has to be freed before returning to
caller.

Fixes: c156232a530b3 ("src: add comment support when adding tables")
Signed-off-by: Phil Sutter <phil@nwl.cc>

diff --git a/src/netlink.c b/src/netlink.c
index 1bbdf98bd2ee25f063047b3a33326c65180849ff..be98bfb7f5c1240c1d2579f63e047c39d4c2415e 100644 (file)
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -647,6 +647,7 @@ struct table *netlink_delinearize_table(struct netlink_ctx *ctx,
                udata = nftnl_table_get_data(nlt, NFTNL_TABLE_USERDATA, &ulen);
                if (nftnl_udata_parse(udata, ulen, table_parse_udata_cb, ud) < 0) {
                        netlink_io_error(ctx, NULL, "Cannot parse userdata");
+                       table_free(table);
                        return NULL;
                }
                if (ud[NFTNL_UDATA_TABLE_COMMENT])