]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: annotate a data-race in __dev_xmit_skb()
authorEric Dumazet <edumazet@google.com>
Fri, 21 Nov 2025 08:32:53 +0000 (08:32 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 25 Nov 2025 15:10:32 +0000 (16:10 +0100)
q->limit is read locklessly, add a READ_ONCE().

Fixes: 100dfa74cad9 ("net: dev_queue_xmit() llist adoption")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20251121083256.674562-12-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/dev.c

index 53e2496dc4292284072946fd9131d3f9a0c0af44..10042139dbb054b9a93dfb019477a80263feb029 100644 (file)
@@ -4194,7 +4194,7 @@ no_lock_out:
        do {
                if (first_n && !defer_count) {
                        defer_count = atomic_long_inc_return(&q->defer_count);
-                       if (unlikely(defer_count > q->limit)) {
+                       if (unlikely(defer_count > READ_ONCE(q->limit))) {
                                kfree_skb_reason(skb, SKB_DROP_REASON_QDISC_DROP);
                                return NET_XMIT_DROP;
                        }