]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: server: Removed inappropriate NULL check in smtp_server_connection_send_rep...
authorStephan Bosch <stephan.bosch@dovecot.fi>
Mon, 11 Dec 2017 03:18:54 +0000 (04:18 +0100)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Mon, 11 Dec 2017 13:43:30 +0000 (15:43 +0200)
Caller holds a reference, so it can never be NULL.
Found by Coverity.

src/lib-smtp/smtp-server-connection.c

index f9355258f72a642e3df30165b9a97b85931a9c9f..9dcf36b3731853d75d0aa787b54afde885cd1d6f 100644 (file)
@@ -675,9 +675,7 @@ smtp_server_connection_send_replies(struct smtp_server_connection *conn)
        smtp_server_connection_timeout_update(conn);
 
        /* accept more commands if possible */
-       if (conn != NULL) {
-               smtp_server_connection_input_resume(conn);
-       }
+       smtp_server_connection_input_resume(conn);
 }
 
 int smtp_server_connection_flush(struct smtp_server_connection *conn)