]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
nft-arp: Drop ineffective conditional
authorPhil Sutter <phil@nwl.cc>
Wed, 19 Sep 2018 13:17:02 +0000 (15:17 +0200)
committerFlorian Westphal <fw@strlen.de>
Mon, 24 Sep 2018 09:49:52 +0000 (11:49 +0200)
Since fw->arp.arhln is of type __u8, its value will never become less
than zero.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
iptables/nft-arp.c

index 7332b6193f16a22e42950f82e66bc245c4fb7e2a..b8e8982653bb3511e16a60e6d9ea73d92dbde519 100644 (file)
@@ -330,9 +330,6 @@ static void nft_arp_parse_payload(struct nft_xt_ctx *ctx,
                        fw->arp.invflags |= ARPT_INV_ARPOP;
                break;
        default:
-               if (fw->arp.arhln < 0)
-                       break;
-
                if (ctx->payload.offset == sizeof(struct arphdr) +
                                           fw->arp.arhln) {
                        get_cmp_data(e, &addr, sizeof(addr), &inv);