]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
cutils: Fix size_to_str() on 32-bit platforms
authorEric Blake <eblake@redhat.com>
Wed, 17 Apr 2019 17:11:00 +0000 (12:11 -0500)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 17 Sep 2019 19:23:34 +0000 (14:23 -0500)
When extracting a human-readable size formatter, we changed 'uint64_t
div' pre-patch to 'unsigned long div' post-patch. Which breaks on
32-bit platforms, resulting in 'inf' instead of intended values larger
than 999GB.

Fixes: 22951aaa
CC: qemu-stable@nongnu.org
Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 754da86714d550c3f995f11a2587395081362e0a)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
util/cutils.c

index e098debdc0cdf34106116068f6ceff181805d2d7..d682c909015725c83f79e1dae0c678b4ac9cb028 100644 (file)
@@ -825,7 +825,7 @@ const char *qemu_ether_ntoa(const MACAddr *mac)
 char *size_to_str(uint64_t val)
 {
     static const char *suffixes[] = { "", "Ki", "Mi", "Gi", "Ti", "Pi", "Ei" };
-    unsigned long div;
+    uint64_t div;
     int i;
 
     /*