]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: rt712-sdca: remove redundant else path of if statement
authorColin Ian King <colin.i.king@gmail.com>
Thu, 8 May 2025 08:45:27 +0000 (09:45 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 8 May 2025 14:41:15 +0000 (23:41 +0900)
There is an if/else check where the else part is executed if
adc_vol_flag is true, this else path checks if adc_vol_flag
is true (which is a redundant second check) and the if path is
always taken. Remove the redundant check and remove the else
path since that can never occur.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250508084527.316380-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt712-sdca-dmic.c

index db011da63bd963f08f695bcc40c4c0e440539f38..4d044dfa3136e50042e1c573253eee5b12f137d1 100644 (file)
@@ -263,12 +263,8 @@ static int rt712_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol,
 
                if (!adc_vol_flag) /* boost gain */
                        ctl = regvalue / 0x0a00;
-               else { /* ADC gain */
-                       if (adc_vol_flag)
-                               ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
-                       else
-                               ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);
-               }
+               else /* ADC gain */
+                       ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
 
                ucontrol->value.integer.value[i] = ctl;
        }