lib-smtp: client: transaction: Prevent NULL dereference in smtp_client_transaction_un...

The trans pointer is used before it is checked for being NULL, which is allowed
for this function.

Problem found by Coverity.

diff --git a/src/lib-smtp/smtp-client-transaction.c b/src/lib-smtp/smtp-client-transaction.c
index 225d9f5ff06c7fef4947041cede0ef7a28de4487..7ed87842449fdaf722ec4bf4549cefc5af0fc8f4 100644 (file)
--- a/src/lib-smtp/smtp-client-transaction.c
+++ b/src/lib-smtp/smtp-client-transaction.c
@@ -603,12 +603,13 @@ void smtp_client_transaction_ref(struct smtp_client_transaction *trans)
 void smtp_client_transaction_unref(struct smtp_client_transaction **_trans)
 {
        struct smtp_client_transaction *trans = *_trans;
-       struct smtp_client_connection *conn = trans->conn;
+       struct smtp_client_connection *conn;
 
        *_trans = NULL;
 
        if (trans == NULL)
                return;
+       conn = trans->conn;
 
        i_assert(trans->refcount > 0);
        if (--trans->refcount > 0)