]> git.ipfire.org Git - thirdparty/bird.git/commitdiff
BFD: Fix reconfiguration of neighbors
authorOndrej Zajicek (work) <santiago@crfreenet.org>
Mon, 30 Sep 2019 17:10:14 +0000 (19:10 +0200)
committerOndrej Zajicek (work) <santiago@crfreenet.org>
Mon, 30 Sep 2019 17:10:14 +0000 (19:10 +0200)
The bfd_reconfigure_neighbors() returned after first reconfigured
neighbor instead of continuing with the next one.

Thanks to Winston Chen for the bugreport and a patch.

proto/bfd/bfd.c

index f774e67b0daf40c4d7cbebdbed7e1576cb85f27e..a3e6d01cce82e82545d500a58dfda89fc720afda 100644 (file)
@@ -837,10 +837,11 @@ bfd_reconfigure_neighbors(struct bfd_proto *p, struct bfd_config *new)
 
        nn->req = on->req;
        nn->active = 1;
-       return;
+       goto next;
       }
 
     bfd_stop_neighbor(p, on);
+  next:;
   }
 
   WALK_LIST(nn, new->neigh_list)