]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: tfp410: Remove a redundant check on existence of bridge->encoder
authorSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 13 May 2024 15:30:59 +0000 (23:30 +0800)
committerRobert Foss <rfoss@kernel.org>
Mon, 13 May 2024 16:31:00 +0000 (18:31 +0200)
Because the existence of bridge->encoder has already been checked before
the simple_bridge_attach() function get called, And drm_bridge_attach()
will quit with a negative error code returned if it fails for some reasons.
Hence, it is guaranteed that the .encoder member of the drm_bridge instance
is not NULL when the tfp410_attach() function get called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-3-sui.jingfeng@linux.dev
drivers/gpu/drm/bridge/ti-tfp410.c

index c7bef5c2392710dbe842778641aec7825f1b77ad..b1b1e4d5a24ae1071176738312945b957ccef0d1 100644 (file)
@@ -133,11 +133,6 @@ static int tfp410_attach(struct drm_bridge *bridge,
        if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
                return 0;
 
-       if (!bridge->encoder) {
-               dev_err(dvi->dev, "Missing encoder\n");
-               return -ENODEV;
-       }
-
        if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT)
                dvi->connector.polled = DRM_CONNECTOR_POLL_HPD;
        else