mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()

If an error occurs after a successful regmap_init_mmio(), regmap_exit()
should be called as already done in the .remove() function.

Switch to devm_regmap_init_mmio() to avoid the leak and simplify the
.remove() function.

Fixes: c414df12bdf7 ("mfd: exynos-lpass: Add missing remove() function")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/38414eecb1096840946756ae86887aea2a489c1b.1745247209.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
index 6a585173230b1348b9773638aaa12c5a1f6f6bc7..6b95927e99be7103002214c10e5383c494a3cceb 100644 (file)
--- a/drivers/mfd/exynos-lpass.c
+++ b/drivers/mfd/exynos-lpass.c
@@ -122,8 +122,8 @@ static int exynos_lpass_probe(struct platform_device *pdev)
        if (IS_ERR(lpass->sfr0_clk))
                return PTR_ERR(lpass->sfr0_clk);
 
-       lpass->top = regmap_init_mmio(dev, base_top,
-                                       &exynos_lpass_reg_conf);
+       lpass->top = devm_regmap_init_mmio(dev, base_top,
+                                          &exynos_lpass_reg_conf);
        if (IS_ERR(lpass->top)) {
                dev_err(dev, "LPASS top regmap initialization failed\n");
                return PTR_ERR(lpass->top);
@@ -145,7 +145,6 @@ static void exynos_lpass_remove(struct platform_device *pdev)
        pm_runtime_disable(&pdev->dev);
        if (!pm_runtime_status_suspended(&pdev->dev))
                exynos_lpass_disable(lpass);
-       regmap_exit(lpass->top);
 }
 
 static int __maybe_unused exynos_lpass_suspend(struct device *dev)