[3687] Two minor changes as a result of code review.

PIDFile::write closes the stream before throwing an exception. Also,
remove the TESTNAME2 file before and after the test.

diff --git a/src/lib/util/pid_file.cc b/src/lib/util/pid_file.cc
index 3bc8e0c7fadc6c8c1dd34a823c600f0a1625e15d..05a860d44153375874b80fd6a4d7d8e760e16276 100644 (file)
--- a/src/lib/util/pid_file.cc
+++ b/src/lib/util/pid_file.cc
@@ -75,13 +75,14 @@ PIDFile::write(int pid) const {
 
     // File is open, write the pid.
     fs << pid << std::endl;
-    if (!fs.good()) {
+
+    bool good = fs.good();
+    fs.close();
+
+    if (!good()) {
         isc_throw(PIDFileError, "Unable to write to PID file '"
                   << filename_ << "'");
     }
-
-    // That's it
-    fs.close();
 }
 
 void

diff --git a/src/lib/util/tests/pid_file_unittest.cc b/src/lib/util/tests/pid_file_unittest.cc
index d883c16e966a7ce5461b20a5761158114f00fd29..faaa195194c210dc56129ff04602654fe81302be 100644 (file)
--- a/src/lib/util/tests/pid_file_unittest.cc
+++ b/src/lib/util/tests/pid_file_unittest.cc
@@ -19,8 +19,9 @@
 namespace {
 using namespace isc::util;
 
-#define TESTNAME "pid_file.test"
-#define TESTNAME2 "pid_file.test.2"
+// Filenames used for testing.
+const char* TESTNAME = "pid_file.test";
+const char* TESTNAME2 = "pid_file.test.2";
 
 class PIDFileTest : public ::testing::Test {
 public:
@@ -63,6 +64,7 @@ private:
     /// @brief Removes any remaining test files
     void removeTestFile() const {
         remove(TESTNAME);
+        remove(TESTNAME2);
     }
 
 };