]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
watchdog: aspeed: fix 64-bit division
authorArnd Bergmann <arnd@arndb.de>
Fri, 14 Mar 2025 16:02:44 +0000 (17:02 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 16 Mar 2025 10:00:34 +0000 (11:00 +0100)
On 32-bit architectures, the new calculation causes a build failure:

ld.lld-21: error: undefined symbol: __aeabi_uldivmod

Since neither value is ever larger than a register, cast both
sides into a uintptr_t.

Fixes: 5c03f9f4d362 ("watchdog: aspeed: Update bootstatus handling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250314160248.502324-1-arnd@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/aspeed_wdt.c

index 369635b38ca0e27a8e7dd06ad3e4aff67f442129..837e15701c0e2768dbf716e85fe3b50928c97058 100644 (file)
@@ -254,7 +254,7 @@ static void aspeed_wdt_update_bootstatus(struct platform_device *pdev,
 
        if (!of_device_is_compatible(pdev->dev.of_node, "aspeed,ast2400-wdt")) {
                res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-               idx = ((intptr_t)wdt->base & 0x00000fff) / resource_size(res);
+               idx = ((intptr_t)wdt->base & 0x00000fff) / (uintptr_t)resource_size(res);
        }
 
        scu_base = syscon_regmap_lookup_by_compatible(scu.compatible);