]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Avoid a ZERO_STRUCT with an explicit initialization
authorVolker Lendecke <vl@samba.org>
Mon, 24 Feb 2025 20:04:32 +0000 (21:04 +0100)
committerMartin Schwenke <martins@samba.org>
Sat, 14 Jun 2025 08:46:34 +0000 (08:46 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
source3/smbd/smb2_trans2.c

index 0370a8332cd5aa4893f385b6f79adefc6c4eac76..3483a413335bac5677e7b45f6fc50d26c73ec7fb 100644 (file)
@@ -1783,7 +1783,10 @@ NTSTATUS smbd_dirptr_lanman2_entry(TALLOC_CTX *ctx,
        uint32_t mode = 0;
        char *fname = NULL;
        struct smb_filename *smb_fname = NULL;
-       struct smbd_dirptr_lanman2_state state;
+       struct smbd_dirptr_lanman2_state state = {
+               .conn = conn,
+               .info_level = info_level,
+       };
        bool ok;
        uint64_t last_entry_off = 0;
        NTSTATUS status;
@@ -1792,9 +1795,6 @@ NTSTATUS smbd_dirptr_lanman2_entry(TALLOC_CTX *ctx,
 
        mangled_names = lp_mangled_names(conn->params);
 
-       ZERO_STRUCT(state);
-       state.conn = conn;
-       state.info_level = info_level;
        if (mangled_names != MANGLED_NAMES_NO) {
                state.check_mangled_names = true;
        }