]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: wm8400: Constify struct regulator_desc
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 9 Sep 2024 18:35:08 +0000 (20:35 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 9 Sep 2024 20:08:42 +0000 (21:08 +0100)
'struct regulator_desc' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
   4419    2512       0    6931    1b13 drivers/regulator/wm8400-regulator.o

After:
=====
   text    data     bss     dec     hex filename
   6307     624       0    6931    1b13 drivers/regulator/wm8400-regulator.o

--
Compile tested only

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/fde33ecfd9bbdbdc1da1620c9f3b1b7a72f9d805.1725906876.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/wm8400-regulator.c

index c4a229f66dec9014d6b50279338d8e51a29d6c85..fb3ca7956d00c653b79f4bba92002794c7469f5c 100644 (file)
@@ -112,7 +112,7 @@ static const struct regulator_ops wm8400_dcdc_ops = {
        .get_optimum_mode = wm8400_dcdc_get_optimum_mode,
 };
 
-static struct regulator_desc regulators[] = {
+static const struct regulator_desc regulators[] = {
        {
                .name = "LDO1",
                .id = WM8400_LDO1,