]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/display/tcx: add missing 64-bit access for framebuffer blitter
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fri, 20 Nov 2020 08:17:54 +0000 (08:17 +0000)
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Sun, 22 Nov 2020 10:43:30 +0000 (10:43 +0000)
Commit ae5643ecc6 "hw/display/tcx: Allow 64-bit accesses to framebuffer stippler
and blitter" enabled 64-bit access for the TCX framebuffer stippler and blitter
but missed applying the change to one of the blitter MemoryRegions.

Whilst the original change works for me on my local NetBSD test image, the latest
NetBSD ISO panics on startup without this fix.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: ae5643ecc6 ("hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter")
Buglink: https://bugs.launchpad.net/bugs/1892540
Message-Id: <20201120081754.18250-1-mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
hw/display/tcx.c

index 878ecc8c50662c92021b4f167c60375bd057aa78..3799d29b75923d7bc6314fc3499d74be3f85d9a1 100644 (file)
@@ -649,10 +649,14 @@ static const MemoryRegionOps tcx_blit_ops = {
     .read = tcx_blit_readl,
     .write = tcx_blit_writel,
     .endianness = DEVICE_NATIVE_ENDIAN,
-    .valid = {
+    .impl = {
         .min_access_size = 4,
         .max_access_size = 4,
     },
+    .valid = {
+        .min_access_size = 4,
+        .max_access_size = 8,
+    },
 };
 
 static const MemoryRegionOps tcx_rblit_ops = {