]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
expression: memleak in verdict_expr_parse_udata()
authorPablo Neira Ayuso <pablo@netfilter.org>
Fri, 5 Mar 2021 19:36:31 +0000 (20:36 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 5 Mar 2021 19:42:21 +0000 (20:42 +0100)
Remove unnecessary verdict_expr_alloc() invocation.

Fixes: 4ab1e5e60779 ("src: allow use of 'verdict' in typeof definitions")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expression.c

index 8c6beef9a5e51bda0d220e14434fe2c0ccf03718..0c5276d1118d4b4926ffb0605011ec0b5f397cb0 100644 (file)
@@ -260,7 +260,7 @@ static int verdict_expr_build_udata(struct nftnl_udata_buf *udbuf,
 
 static struct expr *verdict_expr_parse_udata(const struct nftnl_udata *attr)
 {
-       struct expr *e = verdict_expr_alloc(&internal_location, 0, NULL);
+       struct expr *e;
 
        e = symbol_expr_alloc(&internal_location, SYMBOL_VALUE, NULL, "verdict");
        e->len = NFT_REG_SIZE * BITS_PER_BYTE;