]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: iwlegacy: Fixup allocation failure log
authorBrendan Jackman <jackmanb@google.com>
Thu, 26 Mar 2026 12:31:58 +0000 (12:31 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 7 Apr 2026 13:37:31 +0000 (15:37 +0200)
Fix 2 issues spotted by AI[0]:

1. Missing space after the full stop.

2. Wrong GFP flags are printed.

And also switch to %pGg for the GFP flags. This produces nice readable
output and decouples the format string from the size of gfp_t.

[0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com

Signed-off-by: Brendan Jackman <jackmanb@google.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Link: https://patch.msgid.link/20260326-gfp64-v2-2-d916021cecdf@google.com
[add missing wifi: prefix]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlegacy/3945-mac.c

index c148654aa9533387439049941a4258e6a5bd9840..88b31e0b9568c96f05c5b390b8a6cb06d882004f 100644 (file)
@@ -1002,9 +1002,9 @@ il3945_rx_allocate(struct il_priv *il, gfp_t priority)
                                D_INFO("Failed to allocate SKB buffer.\n");
                        if (rxq->free_count <= RX_LOW_WATERMARK &&
                            net_ratelimit())
-                               IL_ERR("Failed to allocate SKB buffer with %0x."
+                               IL_ERR("Failed to allocate SKB buffer with %pGg. "
                                       "Only %u free buffers remaining.\n",
-                                      priority, rxq->free_count);
+                                      &gfp_mask, rxq->free_count);
                        /* We don't reschedule replenish work here -- we will
                         * call the restock method and if it still needs
                         * more buffers it will schedule replenish */