]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: avoid bit operation on key flags
authorBaochen Qiang <quic_bqiang@quicinc.com>
Fri, 23 May 2025 03:49:01 +0000 (11:49 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Mon, 23 Jun 2025 14:28:33 +0000 (07:28 -0700)
WMI_KEY_PAIRWISE and WMI_KEY_GROUP are not bit fields, change
bit operation to direct assignment to avoid confusion.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00217-QCAHKSWPL_SILICONZ-1

Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250523-ath12k-unicast-key-first-v1-1-f53c3880e6d8@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/mac.c

index 3c9c9066d3201c00708b65f8a6d964dc23913b8b..18c42b714ef37bb49f1112454fae2cf118268ac6 100644 (file)
@@ -4979,9 +4979,9 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd,
        }
 
        if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE)
-               flags |= WMI_KEY_PAIRWISE;
+               flags = WMI_KEY_PAIRWISE;
        else
-               flags |= WMI_KEY_GROUP;
+               flags = WMI_KEY_GROUP;
 
        ret = ath12k_install_key(arvif, key, cmd, peer_addr, flags);
        if (ret) {