]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: rt5033: Fix missing regmap_del_irq_chip()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Wed, 30 Oct 2024 15:41:06 +0000 (23:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 09:59:34 +0000 (10:59 +0100)
[ Upstream commit d256d612f47529ed0b332298e2d5ea981a4dd5b8 ]

Fix missing call to regmap_del_irq_chip() in error handling path by
using devm_regmap_add_irq_chip().

Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1730302867-8391-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/rt5033.c

index 94cdad91c06578bddf8a09f8f4c1aac2934def59..71f35bfac3f288c486f912dc30702aaf0a2f9f12 100644 (file)
@@ -85,8 +85,8 @@ static int rt5033_i2c_probe(struct i2c_client *i2c,
        }
        dev_info(&i2c->dev, "Device found Device ID: %04x\n", dev_id);
 
-       ret = regmap_add_irq_chip(rt5033->regmap, rt5033->irq,
-                       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+       ret = devm_regmap_add_irq_chip(rt5033->dev, rt5033->regmap,
+                       rt5033->irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
                        0, &rt5033_irq_chip, &rt5033->irq_data);
        if (ret) {
                dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n",