]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.1-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Aug 2015 22:34:40 +0000 (15:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Aug 2015 22:34:40 +0000 (15:34 -0700)
added patches:
md-use-kzalloc-when-bitmap-is-disabled.patch

queue-4.1/md-use-kzalloc-when-bitmap-is-disabled.patch [new file with mode: 0644]
queue-4.1/series

diff --git a/queue-4.1/md-use-kzalloc-when-bitmap-is-disabled.patch b/queue-4.1/md-use-kzalloc-when-bitmap-is-disabled.patch
new file mode 100644 (file)
index 0000000..15760c5
--- /dev/null
@@ -0,0 +1,49 @@
+From b6878d9e03043695dbf3fa1caa6dfc09db225b16 Mon Sep 17 00:00:00 2001
+From: Benjamin Randazzo <benjamin@randazzo.fr>
+Date: Sat, 25 Jul 2015 16:36:50 +0200
+Subject: md: use kzalloc() when bitmap is disabled
+
+From: Benjamin Randazzo <benjamin@randazzo.fr>
+
+commit b6878d9e03043695dbf3fa1caa6dfc09db225b16 upstream.
+
+In drivers/md/md.c get_bitmap_file() uses kmalloc() for creating a
+mdu_bitmap_file_t called "file".
+
+5769         file = kmalloc(sizeof(*file), GFP_NOIO);
+5770         if (!file)
+5771                 return -ENOMEM;
+
+This structure is copied to user space at the end of the function.
+
+5786         if (err == 0 &&
+5787             copy_to_user(arg, file, sizeof(*file)))
+5788                 err = -EFAULT
+
+But if bitmap is disabled only the first byte of "file" is initialized
+with zero, so it's possible to read some bytes (up to 4095) of kernel
+space memory from user space. This is an information leak.
+
+5775         /* bitmap disabled, zero the first byte and copy out */
+5776         if (!mddev->bitmap_info.file)
+5777                 file->pathname[0] = '\0';
+
+Signed-off-by: Benjamin Randazzo <benjamin@randazzo.fr>
+Signed-off-by: NeilBrown <neilb@suse.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/md.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/md/md.c
++++ b/drivers/md/md.c
+@@ -5740,7 +5740,7 @@ static int get_bitmap_file(struct mddev
+       char *ptr;
+       int err;
+-      file = kmalloc(sizeof(*file), GFP_NOIO);
++      file = kzalloc(sizeof(*file), GFP_NOIO);
+       if (!file)
+               return -ENOMEM;
index 26042d2847e96c22904c9a8a738388d21ec07081..4069931dac05258e0891462215eeaa788c074e97 100644 (file)
@@ -26,3 +26,4 @@ usb-sierra-add-1199-68ab-device-id.patch
 usb-udc-core-add-device_del-call-to-error-pathway.patch
 usb-chipidea-ehci_init_driver-is-intended-to-call-one-time.patch
 phy-twl4030-usb-make-runtime-pm-more-reliable.patch
+md-use-kzalloc-when-bitmap-is-disabled.patch