Add CHECK_FOR_INTERRUPTS while decoding changes.

While decoding changes in a loop, if we skip all the changes there is no
CFI making the loop uninterruptible.

Reported-by: Whale Song and Andrey Borodin
Bug: 17580
Author: Masahiko Sawada
Reviwed-by: Amit Kapila
Backpatch-through: 10
Discussion: https://postgr.es/m/17580-849c1d5b6d7eb422@postgresql.org
Discussion: https://postgr.es/m/B319ECD6-9A28-4CDF-A8F4-3591E0BF2369@yandex-team.ru

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index ef8c2ea6dfe33b51047072933a53952215795c8d..368f60159da2b816b218554f63ce0d684769dfd1 100644 (file)
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -1577,6 +1577,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,
                        Relation        relation = NULL;
                        Oid                     reloid;
 
+                       CHECK_FOR_INTERRUPTS();
+
                        switch (change->action)
                        {
                                case REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM: