]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
daemon/session2_tasklist_del(): be more defensive
authorVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 24 Apr 2025 08:58:16 +0000 (10:58 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 24 Apr 2025 08:58:16 +0000 (10:58 +0200)
See the 6.x commit 0646b6c3

daemon/session.c

index 4abb7409148f2231a7a86eb0d2ba46d4f809653f..548fe3ea97f25be31a02561e4f6630c56a451de5 100644 (file)
@@ -200,7 +200,8 @@ int session_tasklist_del(struct session *session, struct qr_task *task)
        }
        int ret = trie_del(t, key, key_len, &val);
        if (ret == KNOT_EOK) {
-               kr_require(val == task);
+               if (kr_fails_assert(val == task)) // internal inconsistency in tasklist
+                       return kr_error(EINVAL);
                worker_task_unref(val);
        }
        return ret;