drm/tests: Add test for drm_framebuffer_check_src_coords()

Add a parametrized test for the drm_framebuffer_check_src_coords function.

Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240911001559.28284-6-gcarlos@disroot.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
index 888aadb6a4acbb727f08b8f353c59856dc595808..9cd85ac789bbb08212165f178811fc01de637d2f 100644 (file)
--- a/drivers/gpu/drm/drm_framebuffer.c
+++ b/drivers/gpu/drm/drm_framebuffer.c
@@ -99,6 +99,7 @@ int drm_framebuffer_check_src_coords(uint32_t src_x, uint32_t src_y,
 
        return 0;
 }
+EXPORT_SYMBOL_FOR_TESTS_ONLY(drm_framebuffer_check_src_coords);
 
 /**
  * drm_mode_addfb - add an FB to the graphics configuration

diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
index 2ea3abfd5e7a8df6662e5394a755e4691ec4f019..1924e3f9538e65bf33ad09077441e0f024ec19f4 100644 (file)
--- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
+++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
@@ -10,6 +10,7 @@
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_mode.h>
+#include <drm/drm_framebuffer.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_kunit_helpers.h>
 #include <drm/drm_print.h>
@@ -438,7 +439,67 @@ static void drm_test_framebuffer_modifiers_not_supported(struct kunit *test)
        KUNIT_EXPECT_EQ(test, PTR_ERR(fb), -EINVAL);
 }
 
+/* Parameters for testing drm_framebuffer_check_src_coords function */
+struct drm_framebuffer_check_src_coords_case {
+       const char *name;
+       const int expect;
+       const unsigned int fb_size;
+       const uint32_t src_x;
+       const uint32_t src_y;
+
+       /* Deltas to be applied on source */
+       const uint32_t dsrc_w;
+       const uint32_t dsrc_h;
+};
+
+static const struct drm_framebuffer_check_src_coords_case
+drm_framebuffer_check_src_coords_cases[] = {
+       { .name = "Success: source fits into fb",
+         .expect = 0,
+       },
+       { .name = "Fail: overflowing fb with x-axis coordinate",
+         .expect = -ENOSPC, .src_x = 1, .fb_size = UINT_MAX,
+       },
+       { .name = "Fail: overflowing fb with y-axis coordinate",
+         .expect = -ENOSPC, .src_y = 1, .fb_size = UINT_MAX,
+       },
+       { .name = "Fail: overflowing fb with source width",
+         .expect = -ENOSPC, .dsrc_w = 1, .fb_size = UINT_MAX - 1,
+       },
+       { .name = "Fail: overflowing fb with source height",
+         .expect = -ENOSPC, .dsrc_h = 1, .fb_size = UINT_MAX - 1,
+       },
+};
+
+static void drm_test_framebuffer_check_src_coords(struct kunit *test)
+{
+       const struct drm_framebuffer_check_src_coords_case *params = test->param_value;
+       const uint32_t src_x = params->src_x;
+       const uint32_t src_y = params->src_y;
+       const uint32_t src_w = (params->fb_size << 16) + params->dsrc_w;
+       const uint32_t src_h = (params->fb_size << 16) + params->dsrc_h;
+       const struct drm_framebuffer fb = {
+               .width  = params->fb_size,
+               .height = params->fb_size
+       };
+       int ret;
+
+       ret = drm_framebuffer_check_src_coords(src_x, src_y, src_w, src_h, &fb);
+       KUNIT_EXPECT_EQ(test, ret, params->expect);
+}
+
+static void
+check_src_coords_test_to_desc(const struct drm_framebuffer_check_src_coords_case *t,
+                             char *desc)
+{
+       strscpy(desc, t->name, KUNIT_PARAM_DESC_SIZE);
+}
+
+KUNIT_ARRAY_PARAM(check_src_coords, drm_framebuffer_check_src_coords_cases,
+                 check_src_coords_test_to_desc);
+
 static struct kunit_case drm_framebuffer_tests[] = {
+       KUNIT_CASE_PARAM(drm_test_framebuffer_check_src_coords, check_src_coords_gen_params),
        KUNIT_CASE_PARAM(drm_test_framebuffer_create, drm_framebuffer_create_gen_params),
        KUNIT_CASE(drm_test_framebuffer_modifiers_not_supported),
        { }