]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tty: staging/greybus: pass tty_driver flags to tty_alloc_driver()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Mon, 17 Mar 2025 07:00:37 +0000 (08:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 15:00:51 +0000 (08:00 -0700)
tty_alloc_driver() is supposed to receive tty driver flags.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Acked-by: Johan Hovold <johan@kernel.org>
Cc: David Lin <dtwlin@gmail.com>
Cc: Alex Elder <elder@kernel.org>
Cc: greybus-dev@lists.linaro.org
Cc: linux-staging@lists.linux.dev
Reviewed-by: Alex Elder <elder@riscstar.com>
Link: https://lore.kernel.org/r/20250317070046.24386-23-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/uart.c

index 8eab94cb06faf64dbf171edb7c924cbc00fb3c02..308ed1ca99472bb607343c75456585a00b17b633 100644 (file)
@@ -948,7 +948,8 @@ static int gb_tty_init(void)
 {
        int retval = 0;
 
-       gb_tty_driver = tty_alloc_driver(GB_NUM_MINORS, 0);
+       gb_tty_driver = tty_alloc_driver(GB_NUM_MINORS, TTY_DRIVER_REAL_RAW |
+                                        TTY_DRIVER_DYNAMIC_DEV);
        if (IS_ERR(gb_tty_driver)) {
                pr_err("Can not allocate tty driver\n");
                retval = -ENOMEM;
@@ -961,7 +962,6 @@ static int gb_tty_init(void)
        gb_tty_driver->minor_start = 0;
        gb_tty_driver->type = TTY_DRIVER_TYPE_SERIAL;
        gb_tty_driver->subtype = SERIAL_TYPE_NORMAL;
-       gb_tty_driver->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
        gb_tty_driver->init_termios = tty_std_termios;
        gb_tty_driver->init_termios.c_cflag = B9600 | CS8 |
                CREAD | HUPCL | CLOCAL;