memory: pl353-smc: simplify with dev_err_probe()

Use dev_err_probe() to avoid dmesg flood on actual defer.  This makes
the code also simpler.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240823-b4-cleanup-h-guard-v1-6-01668915bd55@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index 56e51737c81fe9f3e79d3f617bf8db9806945106..c75b99e49970965861d072438c47f2af40a249f6 100644 (file)
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -82,16 +82,14 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
                return -ENOMEM;
 
        pl353_smc->aclk = devm_clk_get(&adev->dev, "apb_pclk");
-       if (IS_ERR(pl353_smc->aclk)) {
-               dev_err(&adev->dev, "aclk clock not found.\n");
-               return PTR_ERR(pl353_smc->aclk);
-       }
+       if (IS_ERR(pl353_smc->aclk))
+               return dev_err_probe(&adev->dev, PTR_ERR(pl353_smc->aclk),
+                                    "aclk clock not found.\n");
 
        pl353_smc->memclk = devm_clk_get(&adev->dev, "memclk");
-       if (IS_ERR(pl353_smc->memclk)) {
-               dev_err(&adev->dev, "memclk clock not found.\n");
-               return PTR_ERR(pl353_smc->memclk);
-       }
+       if (IS_ERR(pl353_smc->memclk))
+               return dev_err_probe(&adev->dev, PTR_ERR(pl353_smc->memclk),
+                                    "memclk clock not found.\n");
 
        err = clk_prepare_enable(pl353_smc->aclk);
        if (err) {