]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: mcq: Move the "hba->mcq_enabled = true" assignment
authorBart Van Assche <bvanassche@acm.org>
Mon, 8 Jul 2024 21:16:02 +0000 (14:16 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 11 Jul 2024 02:19:05 +0000 (22:19 -0400)
Move the "hba->mcq_enabled = true" assignment to prevent that it gets
duplicated by a later patch that will introduce more ufshcd_mcq_enable()
calls.  No functionality is changed by this patch.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240708211716.2827751-8-bvanassche@acm.org
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufs-mcq.c
drivers/ufs/core/ufshcd.c

index 4bcae410c2681e5cfc6010f11f4f64f84cf45841..0a9597a6d0592f49341179b6d1727dd112c9c62b 100644 (file)
@@ -416,6 +416,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_enable_esi);
 void ufshcd_mcq_enable(struct ufs_hba *hba)
 {
        ufshcd_rmwl(hba, MCQ_MODE_SELECT, MCQ_MODE_SELECT, REG_UFS_MEM_CFG);
+       hba->mcq_enabled = true;
 }
 EXPORT_SYMBOL_GPL(ufshcd_mcq_enable);
 
index a40b0bf2922e7187ecbce40359e1051cc5132382..c96c57fe58344d26deb17627d072b9afb322e31a 100644 (file)
@@ -8703,7 +8703,6 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)
        ufshcd_mcq_config_mac(hba, hba->nutrs);
 
        ufshcd_mcq_enable(hba);
-       hba->mcq_enabled = true;
 
        dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
                 hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],