]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: sunxi-ng: fix order of arguments in clock macro
authorAndre Przywara <andre.przywara@arm.com>
Wed, 30 Apr 2025 09:53:25 +0000 (10:53 +0100)
committerChen-Yu Tsai <wens@csie.org>
Thu, 1 May 2025 09:47:49 +0000 (17:47 +0800)
When introducing the SUNXI_CCU_MP_DATA_WITH_MUX_GATE_FEAT macro, the order
of the last two arguments was different between the users and the
definition: features became flags and flags became features.

This just didn't end up in a disaster yet because most users ended up
passing 0 for both arguments, and other clocks (for the new A523 SoC) are
not yet used.

Swap the order of the arguments in the definition, so that users stay
untouched.

Fixes: cdbb9d0d09db ("clk: sunxi-ng: mp: provide wrappers for setting feature flags")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://patch.msgid.link/20250430095325.477311-1-andre.przywara@arm.com
[wens@csie.org: fix typo in commit message]
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
drivers/clk/sunxi-ng/ccu_mp.h

index b35aeec70484d6864c85d93f2052eaed3f3afe5d..8fc7fdb7ef494101f0897b455fc6b8dc5107b572 100644 (file)
@@ -109,8 +109,7 @@ struct ccu_mp {
                                             _mshift, _mwidth,          \
                                             _pshift, _pwidth,          \
                                             _muxshift, _muxwidth,      \
-                                            _gate, _features,          \
-                                            _flags)                    \
+                                            _gate, _flags, _features)  \
        struct ccu_mp _struct = {                                       \
                .enable = _gate,                                        \
                .m      = _SUNXI_CCU_DIV(_mshift, _mwidth),             \